Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Timestamp returned for check in some cases #29

Open
comp615 opened this issue Nov 9, 2022 · 1 comment · May be fixed by #30
Open

Invalid Timestamp returned for check in some cases #29

comp615 opened this issue Nov 9, 2022 · 1 comment · May be fixed by #30

Comments

@comp615
Copy link
Contributor

comp615 commented Nov 9, 2022 •
edited
Loading

Describe the bug
Using this action, sometimes the checks are not correctly run
image

To Reproduce
Steps to reproduce the behavior:

  1. Make a change using the job below
  2. Check results in Apollo. Sometimes nothing is returned and the date range is shown as invalid

Environment

jobs:
  check_schema:
    name: check schema
    runs-on: ubuntu-latest
    timeout-minutes: 5
    steps:
      - uses: actions/checkout@v2
      - name: Apollo Schema check
        uses: iansu/apollo-schema-check-action@v2
        with:
          graph: [[REDACTED]]
          localSchemaFile: 'server/graphql/schema.graphql'
          serviceName: [[REDACTED]]
          validationPeriod: P1W
          key: ${{ secrets.APOLLO_KEY }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Additional context
Continuing to look at this and see if there's any commonalities. Seems likely it might be an issue on the Apollo side of things since I don't know what would have changed here
@comp615
Copy link
Contributor Author

comp615 commented Nov 14, 2022

From Apollo support, they claim that the seconds for from should be negative (i.e. “-604800”). So maybe will try swapping that? Going to run into the how do I test issue again.

@comp615 comp615 linked a pull request Nov 15, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use negative integer for from duration comp615/apollo-schema-check-action
1 participant
@comp615