Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Done and Error pages layout along with removing server side validation during sign in. #78

Merged
merged 6 commits into from
Sep 2, 2020
Merged

Removed Done and Error pages layout along with removing server side validation during sign in. #78

merged 6 commits into from
Sep 2, 2020

Conversation

fabcodingzest
Copy link
Collaborator

Fixes #issuenumber

What type of PR is this?

  • 🚀 Added Feature
  • 🐛 Fixed Bug
  • 📝 Docs Update
  • 🚩 Other

Check everything

  • I have added the issue number for which this pull request is created.
  • I have selected the TradeByte Project in Projects

Description

  • Removed layout for done and error pages.
  • Removed server-side validation on the sign-in as it's being done on the client-side plus it was causing an error in flash messages.

@fabcodingzest fabcodingzest added bug Something isn't working frontend Frontend Task backend Backend Task labels Sep 2, 2020
@fabcodingzest fabcodingzest self-assigned this Sep 2, 2020
@iampavangandhi iampavangandhi linked an issue Sep 2, 2020 that may be closed by this pull request
Fix the flash messages on landing page issue and test the apps to find bugs and improve it. #76
Closed
@iampavangandhi iampavangandhi merged commit 9188d21 into iampavangandhi:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iampavangandhi iampavangandhi Awaiting requested review from iampavangandhi

Assignees

@fabcodingzest fabcodingzest

Labels
backend Backend Task bug Something isn't working frontend Frontend Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the flash messages on landing page issue and test the apps to find bugs and improve it.
2 participants
@fabcodingzest @iampavangandhi