Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the Nav again and enhanced other comp. #33 #34

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

fabcodingzest
Copy link
Collaborator

@fabcodingzest fabcodingzest commented Aug 13, 2020

Fixes #33

What type of PR is this?

  • 🚀 Added Feature
  • 🐛 Fixed Bug
  • 📝 Docs Update
  • 🚩 Other

Check everything

  • I have added the issue number for which this pull request is created.
  • I have selected the TradeByte Project in Projects

Description

I have made the nav Responsive and almost the same as in design, for some front end work I passed href object in routes so I could use them to style the active page accordingly. The market page now looks decent but the portfolio page would need adjustments according to nav. I will improve nav in the future if we get some time but for now, all the important links work so no one should have any problem working with it.

@fabcodingzest fabcodingzest added this to the Week 2 milestone Aug 13, 2020
@iampavangandhi iampavangandhi merged commit 8579537 into master Aug 13, 2020
@iampavangandhi iampavangandhi deleted the fix/#33 branch August 13, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making the navbar responsive and re-doing the code to make it work with other components.
2 participants