Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worked on Cart Frontend and Backend both while fixing some UI issues. Fixes#29 #45

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Worked on Cart Frontend and Backend both while fixing some UI issues. Fixes#29 #45

merged 4 commits into from
Aug 18, 2020

Conversation

fabcodingzest
Copy link
Collaborator

@fabcodingzest fabcodingzest commented Aug 18, 2020 •
edited by iampavangandhi
Loading

Fixes #29

What type of PR is this?

  • 🚀 Added Feature
  • 🐛 Fixed Bug
  • 📝 Docs Update
  • 🚩 Other

Check everything

  • I have added the issue number for which this pull request is created.
  • I have selected the TradeByte Project in Projects

Description

  • Rebuilt the UI of Cart Page
  • Managed the backend and client-side calculations for cart
  • Made the Cart responsive for all sizes
  • Added company logos by making a helper function for fetching the image link
  • Fixed some alignment issues in market and portfolio pages
  • Improved Market Section Cards (the layout still needs improvement)

@fabcodingzest fabcodingzest added bug Something isn't working enhancement New feature or request add feature Want a new feature frontend Frontend Task backend Backend Task labels Aug 18, 2020
@fabcodingzest fabcodingzest added this to the Week 2 milestone Aug 18, 2020
@fabcodingzest fabcodingzest self-assigned this Aug 18, 2020
@iampavangandhi iampavangandhi merged commit 7036d59 into iampavangandhi:master Aug 18, 2020
@fabcodingzest fabcodingzest changed the title Worked on Cart Frontend and Backend both while fixing some UI issues. Fix/#29 Worked on Cart Frontend and Backend both while fixing some UI issues. Fixes#29 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iampavangandhi iampavangandhi Awaiting requested review from iampavangandhi

Assignees

@fabcodingzest fabcodingzest

Labels
add feature Want a new feature backend Backend Task bug Something isn't working enhancement New feature or request frontend Frontend Task
Projects
None yet
Milestone
Week 2
Development

Successfully merging this pull request may close these issues.

View Section and Cart Section
2 participants
@fabcodingzest @iampavangandhi