Commit 41b011b
committed
Spec cleanup: remove orphan input, declare output, sync README
Four inconsistencies found while reviewing the spec surface after the
recent opener-mismatch work:
1. The [!CAUTION] block in the bot comment named the upstream project
('contributor-assistant/github-action') as the step to configure.
This repo is a fork (iainmcgin/cla-github-action), and any other
downstream will have a different step name. Replace with generic
'CLA-assistant step' so the guidance stays accurate regardless of
who consumes the action.
2. action.yml still declared the 'signed-empty-commit-message' input.
No handler in src/ reads it, and the empty-commit feature it paired
with was removed in the earlier Phase 7 cleanup. Drop it.
3. The action emits core.setOutput('opener_not_in_commits', true) at
runtime but did not declare it in action.yml's (previously absent)
outputs section. Add the outputs: block so maintainers can see the
contract and downstream steps can reference it in workflow
expressions like steps.cla.outputs.opener_not_in_commits.
4. The README Inputs Description table was missing both the new
require-opener-as-author row and the pre-existing use-dco-flag row
(the latter is in action.yml since forever but never made it to the
README). Added both, plus a new 'Outputs' section for the output
declared in (3).1 parent db23684 commit 41b011b
4 files changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
146 | 154 | | |
147 | 155 | | |
148 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
| |||
51 | 49 | | |
52 | 50 | | |
53 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
54 | 60 | | |
55 | 61 | | |
56 | 62 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31051 | 31051 | | |
31052 | 31052 | | |
31053 | 31053 | | |
31054 | | - | |
| 31054 | + | |
31055 | 31055 | | |
31056 | 31056 | | |
31057 | 31057 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
0 commit comments