Skip to content

Comparing Differences between sv-react and sv-utilities extraction/transformation functions #174

@hnn0003

Description

@hnn0003

Using AI, researched any differences between saved-views & itwin-saved-views-utilities/itwin-saved-views-service code, with an emphasis on translation/extraction code & their respective tests (where I think we've had the most bugs from mis-match issues).

It's not a perfect comparison, but it did highlight one key issue where sv-utilities code transforms 2d clip vector points to 3d with z=0, while sv-react will just fail/set the clip vector points to undefined if given 2d values when there should be 3d values.

It seems this change was intentionally added to sv-utilities last year via this PR:https://github.com/iTwin/itwin-saved-views-utilities/pull/44 (it just never was pulled into sv-react as well). So I expect that this change is also needed in sv-react.

TEST_PLAN_COMPARISON_RESEARCH_2.md

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions