Schedulescript is not applied with saved view

[johannes-goltz]

Although the saved view is created from a view with schedule script, the script is not applied when the saved view is applied.

See already created azure bug:
Bug 1983509: 4D Schedule related information is not applied with new Saved view widget.

"@itwin/saved-views-react": "1.2.4" is currently used.
There is one thing I found during debugging I do not understand:
saved-views-master\saved-views-master\packages\saved-views-react\src\createViewState.ts:createSpatialViewStateProps

seedViewState.displayStyle.scheduleScript is defined (for a saved view that does not work correctly) but not applied there. Why not ?

[diegopinate]

@johannes-goltz, can you provide an example on what those schedule script look like? Seems we avoided storing it because they can be quite large and would clutter the data in the saved view.

[jjbeckman13]

@diegopinate @johannes-goltz, if I recall correctly, if the SavedView has a timepoint set, then we just load the schedule and apply it to the view. Schedule itself is not persisted on the Saved View.

@johannes-goltz, can you confirm timepoint is present? It is possible that the logic to apply the schedule script on the opening of that view lives in our code.

[johannes-goltz]

@diegopinate @jjbeckman13
Below two screenshots of saved view data from 2 different projects.
The first is the one where the schedule script is not applied. Timepoint property is available.

The second one is a saved view that works (schedule script is applied). There I found the timepoint property and a renderTimeline
property.

Not working saved view (schedule script is not applied):

Working saved view (schedule script is applied)

It seems the first case is not yet handled (applying schedule script) correctly. Only timepoint is provided and no renderTimeline information.

[diegopinate]

Can you give me and @hnn0003 (Heather Root) access to your iModel and send a link, @johannes-goltz?

I see that Pineapple code has code to handle for the missing renderTimeline.

Do you use itwin-saved-views package at all? Or are you only using saved-views-react?

[johannes-goltz]

You and Heather should have access to the project now.
Link to project and iModel:
https://qa-review.itwin.bentley.com/context/3732554b-2eef-4e14-924b-e34e6eb800e5/imodel/382808b7-a123-4a56-a7a4-e8f1a1b9ff23?changeSetId=49562912869ae21d2544ea4afb2d2416682ed38f

the itwin-saved-views-package is legacy and will be replaced by saved-views-react.

[johannes-goltz]

@diegopinate @hnn0003 any progress ? Is there anything I can provide for your investigations ?

[hnn0003]

Hey!
So, we're intentionally not storing all the scheduleScript information in the saved view, because it can get extremely large, and instead we just store enough that the scheduleScript info can be retrieved when a saved-view is applied.

It seems like the old pineapple sv has code to handle applying the scheduleScript correctly here, but we don't currently have anything in saved-views-react or itwin-saved-views-widget to handle the same functionality.

I think (and correct me if I'm wrong here), in talking with @jjbeckman13 and @jzbuchalski, that we determined that should be something added on pineapple's side, in the itwin-saved-views-widget. I think it should pretty much just be adding the same code to the sv-widget whenever a view is applied. I guess I've just been assuming this is on the backlog for pineapple to add support for, but if you want me to help or try and make a PR with changes for the widget myself, I'm happy to do so. @jason-crow , @jjbeckman13 , @jzbuchalski ??

[jason-crow]

Thanks @hnn0003, I think we can just handle this on our side in a saved view plugin. @johannes-goltz can you take a shot at that?