-
Notifications
You must be signed in to change notification settings - Fork 316
Open
Labels
Description
SkyManager shows some architectural weaknesses and it needs to be refactor.
- Extend
SkyManagerfromLayerGeometryand useLayerGeometry.updateinstead ofscene.onBeforeRender
➡️ inherit layer features:events, visibility, freeze, add, delete, update loop - Render pass management features in
C3DEngine, which will facilitate future developments :- allowing users to add their own passes;
- Eye-Dome-Lighting, depth picking.
FXAAEffectcould be replace by multi-pass rendering- create a new pass for
Sky - remove
this.scene, this.scene.onBeforeRender, this.scene.onAfterRender
➡️ useLayer.preUpdate and Layer.postUpdate - use
Layer.object3dto add all object 3D inSkyManager - remove
getter and setter enabled, enable() and disable()that are redundant with each other and
➡️ useLayer.visible
Reactions are currently unavailable