Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please correct AccelLimit in updatePositionAccelController_MC #10669

Open
and-sh opened this issue Feb 3, 2025 · 0 comments
Open

Please correct AccelLimit in updatePositionAccelController_MC #10669

and-sh opened this issue Feb 3, 2025 · 0 comments

Comments

@and-sh
Copy link

and-sh commented Feb 3, 2025

Current Behavior

AccelLimit code suppress pid output even to zero when target and set velocity are close to each over. Pid output is directly linked to banking angle. In result when MC hold position or move with constant velocity banking angle erratically falls to zero.
Pictures are in #10576

Steps to Reproduce

Poshold in windy day.

Expected behavior

Smooth and precision MC moves.

Suggested solution(s)

Disable accel limits. Correct accel limit realization is too complicated and probably not worth the effort to implement.
Banking angle is already limited.

Additional context

All version of Inav have this problem at leat 9 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant