fix: Refactor TeeSessionEnvironmentVariable enum fields to PascalCase (#12)

Author: Natchica

src/api/worker_api.rs

@@ -83,7 +83,7 @@ impl WorkerApiClient {
     /// ```
     pub fn from_env() -> Self {
         let worker_host = get_env_var_or_error(
-            TeeSessionEnvironmentVariable::WORKER_HOST_ENV_VAR,
+            TeeSessionEnvironmentVariable::WorkerHostEnvVar,
             ReplicateStatusCause::PostComputeWorkerAddressMissing,
         )
         .unwrap_or_else(|_| DEFAULT_WORKER_HOST.to_string());
@@ -195,7 +195,7 @@ mod tests {
     #[test]
     fn should_get_worker_api_client_with_env_var() {
         with_vars(
-            vec![(WORKER_HOST_ENV_VAR.name(), Some("custom-worker-host:9999"))],
+            vec![(WorkerHostEnvVar.name(), Some("custom-worker-host:9999"))],
             || {
                 let client = WorkerApiClient::from_env();
                 assert_eq!(client.base_url, "http://custom-worker-host:9999");
@@ -205,7 +205,7 @@ mod tests {
 
     #[test]
     fn should_get_worker_api_client_without_env_var() {
-        with_vars(vec![(WORKER_HOST_ENV_VAR.name(), None::<&str>)], || {
+        with_vars(vec![(WorkerHostEnvVar.name(), None::<&str>)], || {
             let client = WorkerApiClient::from_env();
             assert_eq!(client.base_url, format!("http://{}", DEFAULT_WORKER_HOST));
         });

src/compute/app_runner.rs

@@ -45,7 +45,7 @@ impl DefaultPostComputeRunner {
 impl PostComputeRunnerInterface for DefaultPostComputeRunner {
     fn run_post_compute(&self, chain_task_id: &str) -> Result<(), Box<dyn Error>> {
         let should_callback: bool = match get_env_var_or_error(
-            TeeSessionEnvironmentVariable::RESULT_STORAGE_CALLBACK,
+            TeeSessionEnvironmentVariable::ResultStorageCallback,
             ReplicateStatusCause::PostComputeFailedUnknownIssue, //TODO: Update this error cause to a more specific one
         ) {
             Ok(value) => match value.parse::<bool>() {
@@ -120,7 +120,7 @@ impl PostComputeRunnerInterface for DefaultPostComputeRunner {
 pub fn start_with_runner<R: PostComputeRunnerInterface>(runner: &R) -> i32 {
     println!("Tee worker post-compute started");
     let chain_task_id: String = match get_env_var_or_error(
-        TeeSessionEnvironmentVariable::IEXEC_TASK_ID,
+        TeeSessionEnvironmentVariable::IexecTaskId,
         ReplicateStatusCause::PostComputeTaskIdMissing,
     ) {
         Ok(id) => id,
@@ -132,7 +132,6 @@ pub fn start_with_runner<R: PostComputeRunnerInterface>(runner: &R) -> i32 {
             return 3; // Exit code for missing taskID context
         }
     };
-
     match runner.run_post_compute(&chain_task_id) {
         Ok(()) => {
             info!("TEE post-compute completed");
@@ -201,11 +200,6 @@ pub fn start() -> i32 {
     start_with_runner(&runner)
 }
 
-pub fn run_post_compute(chain_task_id: &str) -> Result<(), Box<dyn Error>> {
-    let runner = DefaultPostComputeRunner::new();
-    runner.run_post_compute(chain_task_id)
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -282,7 +276,7 @@ mod tests {
     fn start_return_valid_exit_code_when_ran() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x123"),
             )],
             || {
@@ -299,7 +293,7 @@ mod tests {
     fn start_return_3_when_task_id_missing() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 None::<&str>,
             )],
             || {
@@ -313,10 +307,7 @@ mod tests {
     #[test]
     fn start_return_3_when_empty_task_id() {
         with_vars(
-            vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
-                Some(""),
-            )],
+            vec![(TeeSessionEnvironmentVariable::IexecTaskId.name(), Some(""))],
             || {
                 let runner = MockRunner::new();
                 let result = start_with_runner(&runner);
@@ -329,7 +320,7 @@ mod tests {
     fn start_return_0_when_successful() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x0"),
             )],
             || {
@@ -344,7 +335,7 @@ mod tests {
     fn start_return_1_when_fail_with_known_cause() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x0"),
             )],
             || {
@@ -365,7 +356,7 @@ mod tests {
     fn start_return_1_when_fail_with_unknown_cause() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x0"),
             )],
             || {
@@ -384,7 +375,7 @@ mod tests {
     fn start_return_2_when_exit_cause_not_transmitted() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x0"),
             )],
             || {
@@ -404,7 +395,7 @@ mod tests {
     fn start_return_2_when_get_challenge_fails() {
         with_vars(
             vec![(
-                TeeSessionEnvironmentVariable::IEXEC_TASK_ID.name(),
+                TeeSessionEnvironmentVariable::IexecTaskId.name(),
                 Some("0x0"),
             )],
             || {

src/compute/signer.rs

@@ -99,11 +99,11 @@ pub fn sign_enclave_challenge(
 /// ```
 pub fn get_challenge(chain_task_id: &str) -> Result<String, ReplicateStatusCause> {
     let worker_address: String = get_env_var_or_error(
-        TeeSessionEnvironmentVariable::SIGN_WORKER_ADDRESS,
+        TeeSessionEnvironmentVariable::SignWorkerAddress,
         ReplicateStatusCause::PostComputeWorkerAddressMissing,
     )?;
     let tee_challenge_private_key: String = get_env_var_or_error(
-        TeeSessionEnvironmentVariable::SIGN_TEE_CHALLENGE_PRIVATE_KEY,
+        TeeSessionEnvironmentVariable::SignTeeChallengePrivateKey,
         ReplicateStatusCause::PostComputeTeeChallengePrivateKeyMissing,
     )?;
     let message_hash: String = concatenate_and_hash(&[chain_task_id, &worker_address]);
@@ -151,11 +151,11 @@ mod tests {
         with_vars(
             vec![
                 (
-                    TeeSessionEnvironmentVariable::SIGN_WORKER_ADDRESS.name(),
+                    TeeSessionEnvironmentVariable::SignWorkerAddress.name(),
                     Some(WORKER_ADDRESS),
                 ),
                 (
-                    TeeSessionEnvironmentVariable::SIGN_TEE_CHALLENGE_PRIVATE_KEY.name(),
+                    TeeSessionEnvironmentVariable::SignTeeChallengePrivateKey.name(),
                     Some(ENCLAVE_CHALLENGE_PRIVATE_KEY),
                 ),
             ],
@@ -184,11 +184,11 @@ mod tests {
         with_vars(
             vec![
                 (
-                    TeeSessionEnvironmentVariable::SIGN_WORKER_ADDRESS.name(),
+                    TeeSessionEnvironmentVariable::SignWorkerAddress.name(),
                     None,
                 ),
                 (
-                    TeeSessionEnvironmentVariable::SIGN_TEE_CHALLENGE_PRIVATE_KEY.name(),
+                    TeeSessionEnvironmentVariable::SignTeeChallengePrivateKey.name(),
                     Some(ENCLAVE_CHALLENGE_PRIVATE_KEY),
                 ),
             ],
@@ -210,11 +210,11 @@ mod tests {
         with_vars(
             vec![
                 (
-                    TeeSessionEnvironmentVariable::SIGN_WORKER_ADDRESS.name(),
+                    TeeSessionEnvironmentVariable::SignWorkerAddress.name(),
                     Some(WORKER_ADDRESS),
                 ),
                 (
-                    TeeSessionEnvironmentVariable::SIGN_TEE_CHALLENGE_PRIVATE_KEY.name(),
+                    TeeSessionEnvironmentVariable::SignTeeChallengePrivateKey.name(),
                     None,
                 ),
             ],

src/compute/utils/env_utils.rs

@@ -2,23 +2,23 @@ use crate::compute::errors::ReplicateStatusCause;
 use std::env;
 
 pub enum TeeSessionEnvironmentVariable {
-    IEXEC_TASK_ID,
-    RESULT_STORAGE_CALLBACK,
-    SIGN_TEE_CHALLENGE_PRIVATE_KEY,
-    SIGN_WORKER_ADDRESS,
-    WORKER_HOST_ENV_VAR,
+    IexecTaskId,
+    ResultStorageCallback,
+    SignTeeChallengePrivateKey,
+    SignWorkerAddress,
+    WorkerHostEnvVar,
 }
 
 impl TeeSessionEnvironmentVariable {
     pub fn name(&self) -> &str {
         match self {
-            TeeSessionEnvironmentVariable::IEXEC_TASK_ID => "IEXEC_TASK_ID",
-            TeeSessionEnvironmentVariable::RESULT_STORAGE_CALLBACK => "RESULT_STORAGE_CALLBACK",
-            TeeSessionEnvironmentVariable::SIGN_TEE_CHALLENGE_PRIVATE_KEY => {
+            TeeSessionEnvironmentVariable::IexecTaskId => "IEXEC_TASK_ID",
+            TeeSessionEnvironmentVariable::ResultStorageCallback => "RESULT_STORAGE_CALLBACK",
+            TeeSessionEnvironmentVariable::SignTeeChallengePrivateKey => {
                 "SIGN_TEE_CHALLENGE_PRIVATE_KEY"
             }
-            TeeSessionEnvironmentVariable::SIGN_WORKER_ADDRESS => "SIGN_WORKER_ADDRESS",
-            TeeSessionEnvironmentVariable::WORKER_HOST_ENV_VAR => "WORKER_HOST",
+            TeeSessionEnvironmentVariable::SignWorkerAddress => "SIGN_WORKER_ADDRESS",
+            TeeSessionEnvironmentVariable::WorkerHostEnvVar => "WORKER_HOST",
         }
     }
 }