From c4db9b5cb8ba2e0718bd1401d0771177fee7c872 Mon Sep 17 00:00:00 2001 From: Maxence Cornaton Date: Fri, 14 Apr 2023 16:11:07 +0200 Subject: [PATCH 1/2] Clean `ReplicateStatus` unused methods --- .../common/replicate/ReplicateStatus.java | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/src/main/java/com/iexec/common/replicate/ReplicateStatus.java b/src/main/java/com/iexec/common/replicate/ReplicateStatus.java index b41594e2..c4390080 100644 --- a/src/main/java/com/iexec/common/replicate/ReplicateStatus.java +++ b/src/main/java/com/iexec/common/replicate/ReplicateStatus.java @@ -63,26 +63,10 @@ public static boolean isSuccess(ReplicateStatus status) { return getSuccessStatuses().contains(status); } - public static boolean isFailure(ReplicateStatus status) { - return getFailureStatuses().contains(status); - } - public static boolean isFailedBeforeComputed(ReplicateStatus status) { return status.ordinal() < COMPUTED.ordinal() && getFailureStatuses().contains(status); } - public static boolean isCompletable(ReplicateStatus status) { - return getCompletableStatuses().contains(status); - } - - public static boolean isFailable(ReplicateStatus status) { - return getFailableStatuses().contains(status); - } - - public static boolean isAbortable(ReplicateStatus status) { - return getAbortableStatuses().contains(status); - } - public static boolean isRecoverable(ReplicateStatus status) { return true; // just temporary } @@ -264,25 +248,6 @@ public static ChainContributionStatus getChainStatus(ReplicateStatus replicateSt } } - public static List getStatusesBeforeContributed() { - return Arrays.asList( - CREATED, - STARTING, - START_FAILED, - STARTED, - APP_DOWNLOADING, - APP_DOWNLOAD_FAILED, - APP_DOWNLOADED, - DATA_DOWNLOADING, - DATA_DOWNLOAD_FAILED, - DATA_DOWNLOADED, - COMPUTING, - COMPUTE_FAILED, - COMPUTED, - CONTRIBUTING, - CONTRIBUTE_FAILED); - } - public static List getMissingStatuses(ReplicateStatus from, ReplicateStatus to) { List statuses = getSuccessStatuses(); if (!statuses.contains(from) || !statuses.contains(to)) { From c9acc1b09b6b154ad9a24071951835d0b152e030 Mon Sep 17 00:00:00 2001 From: Maxence Cornaton Date: Wed, 17 May 2023 10:35:48 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55aba315..5aee3e80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,8 +4,9 @@ All notable changes to this project will be documented in this file. ## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-common/releases/tag/vNEXT) 2023 -### Quality +### Quality - Mark classes from `com.iexec.common.sdk.order`, `com.iexec.common.sdk.order.payload` and `com.iexec.common.chain.eip712` packages deprecated. (#414 #415) +- Clean `ReplicateStatus` unused methods. (#407) ## [[8.1.0]](https://github.com/iExecBlockchainComputing/iexec-common/releases/tag/v8.1.0) 2023-05-11