Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Use consistent and clear naming for mapped data etc. #112

Open
phoeinx opened this issue Feb 21, 2023 · 0 comments
Open

Refactor: Use consistent and clear naming for mapped data etc. #112

phoeinx opened this issue Feb 21, 2023 · 0 comments

Comments

@phoeinx
Copy link
Collaborator

phoeinx commented Feb 21, 2023

As commented by @mweisgut (I think), we should use consistent naming for everything holding a pointer to mapped memory. This ideally shouldn't be map as map is also used for std::map and could be confused.
A new name could perhaps be mmap (which could also be confused with the mmap() call). So mmap_region ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phoeinx