Skip to content

Improve Search Result Side Panel to fix various bugs #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brandon-pereira wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve Search Result Side Panel to fix various bugs #1587

brandon-pereira wants to merge 2 commits into from
+22 −3

Conversation

@brandon-pereira
Copy link
Member

@brandon-pereira brandon-pereira commented Jan 10, 2026

  1. Ensures that multiple scrollbars are not shown for nested panels (click row -> surrounding context -> repeat a few times)
scrollbars
  1. In the same state as above, closing the panel (clicking outside) then clicking another row caused the subpanel to re-open, this isn't ideal (should open to root drawer)
  2. fix issue with drawers where you can scroll, then open a nested drawer, the nested drawer would appear incorrectly
Screenshot 2026-01-09 at 5 10 29 PM

Fixes HDX-3171

@brandon-pereira
Improve Search Result Side Panel to fix various bugs
7457c52 
1. Ensures that multiple scrollbars are not shown for nested panels (click row -> surrounding context -> repeat a few times)
2. In the same state as above, closing the panel (clicking outside) then clicking another row caused the subpanel to re-open, this isn't ideal (should open to root drawer)
3. fix issue with drawers where you can scroll, then open a nested drawer, the nested drawer would appear incorrectly

Fixes HDX-3171
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 79b3235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 10, 2026 0:18am

brandon-pereira
brandon-pereira commented Jan 10, 2026
View reviewed changes
packages/app/src/components/DBRowSidePanel.tsx
<Drawer
opened={rowId != null}
withCloseButton={false}
withinPortal={!isNestedPanel}
Copy link
Member Author

@brandon-pereira brandon-pereira Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally added in #1290 when we didn't sue mantine drawer, not needed anymore.

brandon-pereira
brandon-pereira commented Jan 10, 2026
View reviewed changes
packages/app/src/components/DBRowSidePanel.tsx
opened={rowId != null}
withCloseButton={false}
withinPortal={!isNestedPanel}
withOverlay={!isNestedPanel}
Copy link
Member Author

@brandon-pereira brandon-pereira Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps prevent some issues flagged originally in #1393, ensuring clicking outside closes all modals and that there isn't multiple stacking overlays (causing outside to get darker each sub-modal)

@claude
Copy link

claude bot commented Jan 10, 2026 •
edited
Loading

PR Review

✅ No critical issues found.

Minor observations:

  • In DBSqlRowTableWithSidebar.tsx:64, useNestedPanelState() is called without the isNested parameter. This defaults to undefined, which will use query state. Verify this is intentional for the root drawer component.
  • The prop change from withinPortal to withOverlay in DBRowSidePanel.tsx:562 looks correct for preventing nested scrollbars, but ensure this does not break portal-based positioning in other contexts.

The changes correctly address the nested drawer state management issues described in the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 59 passed • 4 skipped • 748s

Status Count
✅ Passed 59
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brandon-pereira