Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken on Windows #82

Open
DavidPratten opened this issue Nov 14, 2021 · 3 comments
Open

Build is broken on Windows #82

DavidPratten opened this issue Nov 14, 2021 · 3 comments

Comments

@DavidPratten
Copy link

Hi Julian,

I did a clean install of Java SDK 1.7, Maven 3.8.3 and then cloned and built following: https://github.com/julianhyde/morel#download-and-build

I received these failed tests after build.

mavin morel install fail.log

Next steps?

@julianhyde
Copy link
Collaborator

I'm surprised you can build at all using JDK 1.7. With JDK 1.7 I get

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (validate) on project morel: Execution validate of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check: java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/AuditListener : Unsupported major.minor version 52.0

However, ./mvnw clean install works for me if I use JDK 8 and either maven-3.6.3 (the version embedded in mvnw) or maven-3.8.3.

Are you using the latest master, ab10217?

The errors in ShellTest are not that worrying. I think there is a race condition in jline where the echoed input and the output sometimes switch orders. It doesn't happen interactively, only during testing.

Are you running on Windows? The other errors might be due to differences in line endings. I develop on macOS and Linux.

@DavidPratten
Copy link
Author

Gave up on Windows.

From blank Ubuntu WSL2 shell under Windows 10:

$ sudo apt install default-jdk 

Then as per https://github.com/julianhyde/morel#download-and-build

Thanks for the pointers.

David

@julianhyde
Copy link
Collaborator

julianhyde commented Nov 15, 2021

I've re-opened. Even though I don't have a fix, people should know: Build is broken on Windows. Workaround is to not use Windows. Contributions welcome!

@julianhyde julianhyde changed the title Clone and Maven Build Failure Build is broken on Windows Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants