Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies security Options in the new Session API #71

Closed
thoven87 opened this issue Nov 12, 2024 · 5 comments
Closed

Cookies security Options in the new Session API #71

thoven87 opened this issue Nov 12, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@thoven87
Copy link

I have been testing the new Session API, it's been nice so far. I do wonder if there should be options allowed to be passed in different environments context. Say, in production we would like to se a session cookie sameSite as strict to prevent XSS and CSRF attack.

I think this option should be available given that setting a session is mundane task.

@thoven87 thoven87 added the enhancement New feature or request label Nov 12, 2024
@adam-fowler
Copy link
Member

Good point

@adam-fowler
Copy link
Member

#72

@adam-fowler
Copy link
Member

Merged

@thoven87
Copy link
Author

Merged

My computer should arrive either this weekend or early next week. I will test and report. I think the same site enum still needs updated to allow strict as an option and also allows one to set a cookie as both strict and secure.

@adam-fowler
Copy link
Member

I think the same site enum still needs updated to allow strict as an option and also allows one to set a cookie as both strict and secure.

Just realised I messed up the enum (named strict, secure by mistake)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants