Repeating post is marked as such even though a Repeat post is not created for it (due to be scheduled in the past)

[dashaluna]

A Repeat post is created only if date of a Repeating post + it's schedule is in the future.

When you setup a post to be a Repeating post with a schedule such that a Repeat post date happens to be in the past (read example below), the Repeat post is not created. However, the Repeating post is marked as Repeating. This is confusing!

Solution: an error message should be displayed in such case while trying to save a post with a Repeating schedule. That post won't be saved as Repeating post.

Example: main post (that we're wanting to set as a Repeating post) is published on the 10th October and we're setting it to be a Daily Repeating post. So a daily repeat post would have been scheduled for the 11th October. However, if present time (when we're saving changes) is anything past the 11th October, say the 12th October - then Repeat post date is in the past and therefore it is not published.

[willmot]

Hmm, this is an odd case. I wonder what we would expect would happen here? In your example above, if it was Oct 15th when you published the post with the publish date set to Oct 11th, would you expect a daily repeat post to be created for Oct 12th, 13th, 14th and 15th (assuming it was already past the time on the 15th when the repeat post would publish that day)?

At a minimum, I would just expect that we don't let people use past publish posts with the repeating status.

[dashaluna]

I guess it's an odd case, it mainly arose as a result of me reusing existing old posts to make them Repeating, so that I can see Repeat posts being created (without creating new posts).

This could easily happen when a user doesn't look at the date of an already published post that's being made Repeatable (easy thing to do).

I'm not sure what's the best approach here. However, at the moment it's confusing as you can make a past post to be Repeatable and it says so on it, but no Repeat posts are created - feels like bug if you don't dig into the code.

At a minimum, I would just expect that we don't let people use past publish posts with the repeating status.

I think that's a big restriction. Can we somehow check and disable schedule selection that would result in Repeat post being in the past?

For example: if you have a past post published Oct 1st 2016. Then if I want to go in and edit it as being Repeatable with year schedule I should be able to if current date is anything before Oct 1st 2017.

How about this approach: if the next calculated Repeat post date is in the past, we ignore those, and start from the current time + notify a user to confirm that's understood and accepted?

Example:
Past post: Oct 1st time 1pm
Current date: Dec 1st

I came in and made the past post repeatable daily, so I'd except it will start from Dec 1st - if current time is before 1pm and from Dec 2nd if current time is after 1pm?

[willmot]

Yeah I think that sounds like the best approach 👍

…

On Jan 22, 2018 at 6:40 pm, <Dasha Luna ***@***.***)> wrote: I guess it's an odd case, it mainly arose as a result of me reusing existing old posts to make them Repeating, so that I can see Repeat posts being created (without creating new posts). This could easily happen when a user doesn't look at the date of an already published post that's being made Repeatable (easy thing to do). I'm not sure what's the best approach here. However, at the moment it's confusing as you can make a past post to be Repeatable and it says so on it, but no Repeat posts are created - feels like bug if you don't dig into the code. > > > At a minimum, I would just expect that we don't let people use past publish posts with the repeating status. > > I think that's a big restriction. Can we somehow check and disable schedule selection that would result in Repeat post being in the past? For example: if you have a past post published Oct 1st 2016. Then if I want to go in and edit it as being Repeatable with year schedule I should be able to if current date is anything before Oct 1st 2017. How about this approach: if the next calculated Repeat post date is in the past, we ignore those, and start from the current time + notify a user to confirm that's understood and accepted? Example: Past post: Oct 1st time 1pm Current date: Dec 1st I came in and made the past post repeatable daily, so I'd except it will start from Dec 1st - if current time is before 1pm and from Dec 2nd if current time is after 1pm? — You are receiving this because you commented. Reply to this email directly, view it on GitHub (#35 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAS1G-HSXd-nweL7lDMiEZZ1GwgBUDSEks5tNNY5gaJpZM4Rm86L).