Fix Swift compiler warnings

Author: hugocornellier

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.1.6
+
+* Fix Swift compiler warnings: remove unused variables in DeviceEnumerator, PhotoHandler, RecordHandler, and CameraSession
+
 ## 1.1.5
 
 * Fix SPM integration by adding missing FlutterFramework dependency to iOS and macOS Package.swift

README.md

@@ -30,7 +30,7 @@ Add `camera_desktop` alongside `camera` in your `pubspec.yaml`:
 ```yaml
 dependencies:
   camera: ^0.11.0
-  camera_desktop: ^1.1.5
+  camera_desktop: ^1.1.6
 ```
 
 That's it. All three desktop platforms are covered, no additional packages needed.

example/pubspec.lock

@@ -63,7 +63,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.1.5"
+    version: "1.1.6"
   camera_platform_interface:
     dependency: "direct main"
     description:

ios/camera_desktop.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'camera_desktop'
-  s.version          = '1.1.5'
+  s.version          = '1.1.6'
   s.summary          = 'Flutter camera plugin (iOS stub).'
   s.description      = <<-DESC
 Flutter camera plugin for desktop platforms. iOS stub for platform declaration.

macos/camera_desktop.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'camera_desktop'
-  s.version          = '1.1.5'
+  s.version          = '1.1.6'
   s.summary          = 'Flutter camera plugin for macOS using AVFoundation.'
   s.description      = <<-DESC
 A Flutter camera plugin for desktop platforms. On macOS, uses AVFoundation

macos/camera_desktop/Sources/camera_desktop/CameraSession.swift

@@ -251,11 +251,9 @@ class CameraSession: NSObject {
         let desiredPreset = DeviceEnumerator.sessionPreset(for: config.resolutionPreset)
         let fallbackPresets: [AVCaptureSession.Preset] = [.hd1920x1080, .hd1280x720, .high, .medium]
         var chosenPreset: AVCaptureSession.Preset = .medium
-        var usedFallback = false
         if device.supportsSessionPreset(desiredPreset) && session.canSetSessionPreset(desiredPreset) {
             chosenPreset = desiredPreset
         } else {
-            usedFallback = true
             for fp in fallbackPresets {
                 if device.supportsSessionPreset(fp) && session.canSetSessionPreset(fp) {
                     chosenPreset = fp
@@ -371,8 +369,6 @@ class CameraSession: NSObject {
                        name: .AVCaptureSessionInterruptionEnded,
                        object: session)
 
-        let mirrorEnabled = vOutput.connection(with: .video)?.isVideoMirrored ?? false
-
         captureSession = session
         pendingInitResult = result
         firstFrameReceived = false
@@ -451,7 +447,7 @@ class CameraSession: NSObject {
 
         sessionQueue.async { [self] in
             do {
-                let path = try self.recordHandler.startRecording(
+                _ = try self.recordHandler.startRecording(
                     width: self.actualWidth,
                     height: self.actualHeight,
                     targetFps: self.config.targetFps,
@@ -480,8 +476,6 @@ class CameraSession: NSObject {
         }
 
         recordHandler.stopRecording { path in
-            if let path = path {
-            }
             DispatchQueue.main.async {
                 if let path = path {
                     result(path)

macos/camera_desktop/Sources/camera_desktop/DeviceEnumerator.swift

@@ -38,10 +38,7 @@ class DeviceEnumerator {
             return aScore < bScore
         }
 
-        let result = sorted.map { $0.1 }
-        for (device, _) in sorted {
-        }
-        return result
+        return sorted.map { $0.1 }
     }
 
     /// Returns a sort score for camera ordering.

macos/camera_desktop/Sources/camera_desktop/PhotoHandler.swift

@@ -8,8 +8,6 @@ class PhotoHandler {
     /// Takes a picture from the given pixel buffer and writes a JPEG to the output path.
     /// Returns true on success, false on failure.
     static func takePicture(from buffer: CVPixelBuffer, outputPath: String) -> Bool {
-        let width = CVPixelBufferGetWidth(buffer)
-        let height = CVPixelBufferGetHeight(buffer)
         let ciImage = CIImage(cvPixelBuffer: buffer)
         let colorSpace = CGColorSpaceCreateDeviceRGB()
         guard let jpegData = ciContext.jpegRepresentation(

macos/camera_desktop/Sources/camera_desktop/RecordHandler.swift

@@ -197,7 +197,6 @@ class RecordHandler: NSObject {
             if writer.status == .completed {
                 completion(path)
             } else {
-                let errorMsg = writer.error?.localizedDescription ?? "unknown error"
                 completion(nil)
             }
         }

pubspec.yaml

@@ -3,7 +3,7 @@ description: >-
   A Flutter camera plugin for desktop platforms (Linux, macOS, Windows).
   Implements camera_platform_interface for easy integration
   with the standard camera package.
-version: 1.1.5
+version: 1.1.6
 homepage: https://github.com/hugocornellier/camera_desktop
 repository: https://github.com/hugocornellier/camera_desktop
 issue_tracker: https://github.com/hugocornellier/camera_desktop/issues