Remove debug logging, update documentation

Author: hugocornellier

.github/workflows/ci.yml

@@ -85,7 +85,7 @@ jobs:
         shell: bash
         run: |
           grep -q '/utf-8' windows/CMakeLists.txt \
-            || { echo "::error::windows/CMakeLists.txt is missing /utf-8 — see chinese-pc-compat.md"; exit 1; }
+            || { echo "::error::windows/CMakeLists.txt is missing /utf-8"; exit 1; }
 
       - name: Verify ci/cp936_repro.cpp covers every non-ASCII char in windows/
         shell: bash
@@ -108,25 +108,25 @@ jobs:
           set CL_EXIT=%errorlevel%
           type cl.log
           if %CL_EXIT% equ 0 (
-            echo ::error::Expected C4819/C2220 but compile succeeded — CP936 simulation is not triggering the bug
+            echo ::error::Expected C4819/C2220 but compile succeeded, CP936 simulation is not triggering the bug
             exit /b 1
           )
           findstr /c:"C4819" cl.log >nul
           if errorlevel 1 (
-            echo ::error::cl.exe failed but did not emit C4819 — test is not reproducing the real bug
+            echo ::error::cl.exe failed but did not emit C4819, test is not reproducing the real bug
             exit /b 1
           )
           findstr /c:"C2220" cl.log >nul
           if errorlevel 1 (
-            echo ::error::cl.exe failed but did not emit C2220 — /WX promotion is not working as expected
+            echo ::error::cl.exe failed but did not emit C2220, /WX promotion is not working as expected
             exit /b 1
           )
           echo OK: CP936 simulation reproduced C4819/C2220 as expected
           exit /b 0
 
       # Note: MSVC refuses `/source-charset:.936` together with `/utf-8`
       # (error D8016: options are incompatible). On a real Chinese Windows
-      # host, CP936 is NOT a flag — it's an implicit default from GetACP().
+      # host, CP936 is NOT a flag; it's an implicit default from GetACP().
       # `/utf-8` overrides that implicit default. We prove the fix in two
       # independent invocations: the previous step shows CP936 is hostile
       # to our bytes; this step shows `/utf-8` makes MSVC read them as UTF-8
@@ -151,7 +151,7 @@ jobs:
           fi
           echo "Inspecting: $vcxproj"
           if ! grep -q '/utf-8' "$vcxproj"; then
-            echo "::error::/utf-8 missing from $vcxproj — CMake did not thread the flag through"
+            echo "::error::/utf-8 missing from $vcxproj, CMake did not thread the flag through"
             echo "--- vcxproj contents ---"
             cat "$vcxproj"
             exit 1

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.4
+
+* Update documentation
+* Remove debug logging from image stream pause/resume and video recording completion
+
 ## 1.1.3
 
 * Fix Windows build failure (C4819 / C2220) on hosts with a non-UTF-8 system code page (e.g. CP936 on Simplified Chinese Windows) by compiling the plugin with `/utf-8` under MSVC (#2)
@@ -19,7 +24,7 @@
 * Request camera access via `org.freedesktop.portal.Camera` D-Bus interface
 * Enumerate PipeWire camera nodes via `GstDeviceMonitor`
 * Fall back to V4L2 if portal is unavailable or user denies permission
-* No new build dependencies — uses GIO (D-Bus) and GStreamer APIs already linked
+* No new build dependencies: uses GIO (D-Bus) and GStreamer APIs already linked
 
 ## 1.0.8
 

README.md

@@ -30,7 +30,7 @@ Add `camera_desktop` alongside `camera` in your `pubspec.yaml`:
 ```yaml
 dependencies:
   camera: ^0.11.0
-  camera_desktop: ^1.1.2
+  camera_desktop: ^1.1.4
 ```
 
 That's it. All three desktop platforms are covered, no additional packages needed.

ci/check_unicode_inventory.py

@@ -34,7 +34,7 @@ def main() -> int:
         + list(pathlib.Path("windows").glob("*.h"))
     )
     if not windows_sources:
-        print("::error::No windows/*.cpp|*.h files found — run from repo root.")
+        print("::error::No windows/*.cpp|*.h files found, run from repo root.")
         return 1
 
     real: set[str] = set()

ci/cp936_repro.cpp

@@ -21,5 +21,5 @@
 //   U+2264 LESS-THAN OR EQUAL TO        ≤
 //   U+2500 BOX DRAWINGS LIGHT HORIZONTAL ─
 //
-// No code needed — /c (compile only) is sufficient to trigger C4819 on the
+// No code needed: /c (compile only) is sufficient to trigger C4819 on the
 // comment bytes above.

example/pubspec.lock

@@ -63,7 +63,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.1.3"
+    version: "1.1.4"
   camera_platform_interface:
     dependency: "direct main"
     description:
@@ -266,10 +266,10 @@ packages:
     dependency: transitive
     description:
       name: matcher
-      sha256: "12956d0ad8390bbcc63ca2e1469c0619946ccb52809807067a7020d57e647aa6"
+      sha256: dc0b7dc7651697ea4ff3e69ef44b0407ea32c487a39fff6a4004fa585e901861
       url: "https://pub.dev"
     source: hosted
-    version: "0.12.18"
+    version: "0.12.19"
   material_color_utilities:
     dependency: transitive
     description:
@@ -471,10 +471,10 @@ packages:
     dependency: transitive
     description:
       name: test_api
-      sha256: "93167629bfc610f71560ab9312acdda4959de4df6fac7492c89ff0d3886f6636"
+      sha256: "8161c84903fd860b26bfdefb7963b3f0b68fee7adea0f59ef805ecca346f0c7a"
       url: "https://pub.dev"
     source: hosted
-    version: "0.7.9"
+    version: "0.7.10"
   typed_data:
     dependency: transitive
     description:

ios/camera_desktop.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'camera_desktop'
-  s.version          = '1.1.2'
+  s.version          = '1.1.4'
   s.summary          = 'Flutter camera plugin (iOS stub).'
   s.description      = <<-DESC
 Flutter camera plugin for desktop platforms. iOS stub for platform declaration.

lib/src/camera_desktop_plugin.dart

@@ -428,15 +428,8 @@ class CameraDesktopPlugin extends CameraPlatform {
         // Native has stopped, safe to release FFI resources.
         ffi?.dispose();
       },
-      onPause: () {
-        debugPrint(
-          '[camera_desktop] Warning: pausing image stream '
-          'subscription has no effect, native frames continue flowing.',
-        );
-      },
-      onResume: () {
-        debugPrint('[camera_desktop] Image stream subscription resumed.');
-      },
+      onPause: () {},
+      onResume: () {},
     );
 
     return controller.stream;
@@ -503,25 +496,6 @@ class CameraDesktopPlugin extends CameraPlatform {
           'Native stopVideoRecording returned no output path.',
         );
       }
-      final width = map['width'] as int?;
-      final height = map['height'] as int?;
-      final fps = map['fps'] as int?;
-      final bitrate = map['bitrate'] as int?;
-      final container = map['container'] as String?;
-      final videoCodec = map['videoCodec'] as String?;
-      final audioCodec = map['audioCodec'] as String?;
-      if (width != null && height != null && fps != null && bitrate != null) {
-        debugPrint(
-          '[camera_desktop] Video recorded: ${width}x$height @ ${fps}fps, '
-          'bitrate=${bitrate}bps, path=$path',
-        );
-      }
-      if (container != null || videoCodec != null || audioCodec != null) {
-        debugPrint(
-          '[camera_desktop] Format: container=$container, '
-          'video=$videoCodec, audio=$audioCodec',
-        );
-      }
       return XFile(path);
     } on PlatformException catch (e) {
       throw CameraException(e.code, e.message);

linux/camera.cc

@@ -500,7 +500,7 @@ void Camera::TakePicture(FlMethodCall* method_call) {
                       capture_seq.fetch_add(1, std::memory_order_relaxed));
 
   // C-7: gst_video_convert_sample performs synchronous JPEG encoding which
-  // can take 30–200 ms at 1080p. Offload to a GLib thread-pool task so the
+  // can take 30-200 ms at 1080p. Offload to a GLib thread-pool task so the
   // main/UI thread is never blocked.
   //
   // Take a GStreamer reference to appsink_ so it stays alive for the duration

linux/pipewire_portal.cc

@@ -182,7 +182,7 @@ void PipeWirePortal::OnPortalResponse(GDBusConnection* connection,
                                        gpointer user_data) {
   auto* self = static_cast<PipeWirePortal*>(user_data);
 
-  // Unsubscribe immediately — one-shot signal.
+  // Unsubscribe immediately (one-shot signal).
   if (self->signal_subscription_id_ > 0) {
     g_dbus_connection_signal_unsubscribe(connection,
                                          self->signal_subscription_id_);