refactor(libcommon): remove unused duckdb_index_is_partial()
#3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
force-pushed
the
remove-rowsindex-partial
branch
from
02564d9 to
52f5a81
Compare
lhoestq
reviewed
Nov 4, 2025
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
I think we need partial for create_response() no ?
kszucs
force-pushed
the
remove-rowsindex-partial
branch
from
52f5a81 to
1b79a16
Compare
Member
Author
|
|
…dex_is_partial()`
kszucs
force-pushed
the
remove-rowsindex-partial
branch
from
1b79a16 to
3c67982
Compare
kszucs
changed the title
RowsIndex.partial and duckdb_index_is_partial()duckdb_index_is_partial()
Member
Author
It is indeed required for the response, restored it. |
kszucs
force-pushed
the
remove-rowsindex-partial
branch
from
afbefe5 to
21599e4
Compare
lhoestq
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3253