fix CI (#1884)

coyotte508 · web-flow · commit 2f9395617fdc · 2025-10-02T16:28:05.000+02:00
* fix CI

* add playwright as dev dep

* lint

* clean up spaces-config with community tools

* try to make mongo run?
diff --git a/.env b/.env
@@ -4,7 +4,7 @@
 ### Models ###
 # Models are sourced exclusively from an OpenAI-compatible base URL.
 # Example: https://router.huggingface.co/v1
-OPENAI_BASE_URL=
+OPENAI_BASE_URL=https://router.huggingface.co/v1
 
 # Canonical auth token for any OpenAI-compatible provider
 OPENAI_API_KEY=#your provider API key (works for HF router, OpenAI, LM Studio, etc.)
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -24,6 +24,7 @@ module.exports = {
 		extraFileExtensions: [".svelte"],
 	},
 	rules: {
+		"no-empty": "off",
 		"require-yield": "off",
 		"@typescript-eslint/no-explicit-any": "error",
 		"@typescript-eslint/no-non-null-assertion": "error",
diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml
@@ -39,6 +39,7 @@ jobs:
           cache: "npm"
       - run: |
           npm ci
+          npx playwright install
       - name: "Tests"
         run: |
           npm run test
diff --git a/Dockerfile b/Dockerfile
@@ -21,7 +21,7 @@ RUN touch /app/.env.local
 
 USER root
 RUN apt-get update
-RUN apt-get install -y libgomp1
+RUN apt-get install -y libgomp1 libcurl4
 
 # ensure npm cache dir exists before adjusting ownership
 RUN mkdir -p /home/user/.npm && chown -R 1000:1000 /home/user/.npm
diff --git a/PRIVACY.md b/PRIVACY.md
@@ -26,7 +26,6 @@ Security and routing facts
 
 External providers are responsible for their own security and data handling. Please consult each provider’s respective security and privacy policies via the Inference Providers documentation linked above.
 
-
 ## Technical details
 
 [![chat-ui](https://img.shields.io/github/stars/huggingface/chat-ui)](https://github.com/huggingface/chat-ui)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -48,6 +48,7 @@
 		"js-yaml": "^4.1.0",
 		"minimist": "^1.2.8",
 		"mongodb-memory-server": "^10.1.2",
+		"playwright": "^1.55.1",
 		"prettier": "^3.5.3",
 		"prettier-plugin-svelte": "^3.2.6",
 		"prettier-plugin-tailwindcss": "^0.6.11",
diff --git a/src/lib/components/NavMenu.svelte b/src/lib/components/NavMenu.svelte
@@ -42,7 +42,6 @@
 
 	let {
 		conversations = $bindable(),
-		canLogin,
 		user,
 		p = $bindable(0),
 		ondeleteConversation,
diff --git a/src/lib/components/WelcomeModal.svelte b/src/lib/components/WelcomeModal.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
 	import Modal from "$lib/components/Modal.svelte";
-	import Logo from "$lib/components/icons/Logo.svelte";
 	import IconOmni from "$lib/components/icons/IconOmni.svelte";
 	import { usePublicConfig } from "$lib/utils/PublicConfig.svelte";
 
diff --git a/src/lib/components/chat/ChatWindow.svelte b/src/lib/components/chat/ChatWindow.svelte
@@ -298,7 +298,9 @@
 
 					const blob = await response.blob();
 					const name = attachment.src.split("/").pop() ?? "attachment";
-					loadedFiles.push(new File([blob], name, { type: blob.type || "application/octet-stream" }));
+					loadedFiles.push(
+						new File([blob], name, { type: blob.type || "application/octet-stream" })
+					);
 				} catch (err) {
 					console.error("Error loading attachment:", err);
 				}
diff --git a/src/lib/components/chat/MarkdownRenderer.svelte b/src/lib/components/chat/MarkdownRenderer.svelte
@@ -86,10 +86,6 @@
 		<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 		{@html token.html}
 	{:else if token.type === "code"}
-		<CodeBlock
-			code={token.code}
-			rawCode={token.rawCode}
-			loading={loading && !token.isClosed}
-		/>
+		<CodeBlock code={token.code} rawCode={token.rawCode} loading={loading && !token.isClosed} />
 	{/if}
 {/each}
diff --git a/src/lib/migrations/routines/06-trim-message-updates.ts b/src/lib/migrations/routines/06-trim-message-updates.ts
@@ -12,7 +12,11 @@ import { logger } from "$lib/server/logger";
 function convertMessageUpdate(message: Message, update: unknown): MessageUpdate | null {
 	try {
 		// Trim legacy web search updates entirely
-		if (typeof update === "object" && update !== null && (update as any).type === "webSearch") {
+		if (
+			typeof update === "object" &&
+			update !== null &&
+			(update as { type: string }).type === "webSearch"
+		) {
 			return null;
 		}
 
diff --git a/src/lib/server/api/routes/groups/misc.ts b/src/lib/server/api/routes/groups/misc.ts
@@ -63,36 +63,6 @@ export const misc = new Elysia()
 			isAdmin: locals.isAdmin,
 		} satisfies FeatureFlags;
 	})
-	.get("/spaces-config", async ({ query }) => {
-		if (config.COMMUNITY_TOOLS !== "true") {
-			throw new Error("Community tools are not enabled");
-		}
-
-		const space = query.space;
-
-		if (!space) {
-			throw new Error("Missing space");
-		}
-
-		// Extract namespace from space URL or use as-is if it's already in namespace format
-		let namespace = null;
-		if (space.startsWith("https://huggingface.co/spaces/")) {
-			namespace = space.split("/").slice(-2).join("/");
-		} else if (space.match(/^[^/]+\/[^/]+$/)) {
-			namespace = space;
-		}
-
-		if (!namespace) {
-			throw new Error("Invalid space name. Specify a namespace or a full URL on huggingface.co.");
-		}
-
-		try {
-			const api = await (await Client.connect(namespace)).view_api();
-			return api as ApiReturnType;
-		} catch (e) {
-			throw new Error("Error fetching space API. Is the name correct?");
-		}
-	})
 	.get("/export", async ({ locals }) => {
 		if (!locals.user) {
 			throw new Error("Not logged in");
diff --git a/src/lib/server/endpoints/openai/endpointOai.ts b/src/lib/server/endpoints/openai/endpointOai.ts
@@ -123,7 +123,7 @@ export async function endpointOai(
 				stop: parameters?.stop,
 				temperature: parameters?.temperature,
 				top_p: parameters?.top_p,
-					frequency_penalty: parameters?.frequency_penalty,
+				frequency_penalty: parameters?.frequency_penalty,
 				presence_penalty: parameters?.presence_penalty,
 			};
 
@@ -173,7 +173,7 @@ export async function endpointOai(
 				stop: parameters?.stop,
 				temperature: parameters?.temperature,
 				top_p: parameters?.top_p,
-					frequency_penalty: parameters?.frequency_penalty,
+				frequency_penalty: parameters?.frequency_penalty,
 				presence_penalty: parameters?.presence_penalty,
 			};
 
diff --git a/src/lib/server/endpoints/openai/openAIChatToTextGenerationStream.ts b/src/lib/server/endpoints/openai/openAIChatToTextGenerationStream.ts
@@ -16,9 +16,10 @@ export async function* openAIChatToTextGenerationStream(
 	let thinkOpen = false;
 
 	for await (const completion of completionStream) {
+		const retyped = completion as { "x-router-metadata"?: { route: string; model: string } };
 		// Check if this chunk contains router metadata (first chunk from llm-router)
-		if (!metadataYielded && (completion as any)["x-router-metadata"]) {
-			const metadata = (completion as any)["x-router-metadata"];
+		if (!metadataYielded && retyped["x-router-metadata"]) {
+			const metadata = retyped["x-router-metadata"];
 			yield {
 				token: {
 					id: tokenId++,
@@ -44,8 +45,11 @@ export async function* openAIChatToTextGenerationStream(
 			}
 		}
 		const { choices } = completion;
-		const delta: any = choices?.[0]?.delta ?? {};
-		const content: string = (delta?.content as string) ?? "";
+		const delta: OpenAI.Chat.Completions.ChatCompletionChunk.Choice.Delta & {
+			reasoning?: string;
+			reasoning_content?: string;
+		} = choices?.[0]?.delta ?? {};
+		const content: string = delta.content ?? "";
 		const reasoning: string =
 			typeof delta?.reasoning === "string"
 				? (delta.reasoning as string)
@@ -158,7 +162,10 @@ export async function* openAIChatToTextGenerationSingle(
 	completion: OpenAI.Chat.Completions.ChatCompletion,
 	getRouterMetadata?: () => { route?: string; model?: string }
 ) {
-	const message: any = completion.choices?.[0]?.message ?? {};
+	const message: NonNullable<OpenAI.Chat.Completions.ChatCompletion.Choice>["message"] & {
+		reasoning?: string;
+		reasoning_content?: string;
+	} = completion.choices?.[0]?.message ?? {};
 	let content: string = message?.content || "";
 	// Provider-dependent reasoning shapes (non-streaming)
 	const r: string =
diff --git a/src/lib/server/models.ts b/src/lib/server/models.ts
@@ -64,7 +64,7 @@ const modelConfig = z.object({
 			stop: z.array(z.string()).optional(),
 			top_p: z.number().positive().optional(),
 			top_k: z.number().positive().optional(),
-				frequency_penalty: z.number().min(-2).max(2).optional(),
+			frequency_penalty: z.number().min(-2).max(2).optional(),
 			presence_penalty: z.number().min(-2).max(2).optional(),
 		})
 		.passthrough()
@@ -220,6 +220,8 @@ if (modelOverrides.length) {
 		if (!override) return model;
 
 		const { id, name, ...rest } = override;
+		void id;
+		void name;
 
 		return {
 			...model,
@@ -291,7 +293,7 @@ const routerAliasId = (config.PUBLIC_LLM_ROUTER_ALIAS_ID || "omni").trim() || "o
 const routerMultimodalEnabled =
 	(config.LLM_ROUTER_ENABLE_MULTIMODAL || "").toLowerCase() === "true";
 
-let decorated = builtModels as any[];
+let decorated = builtModels as ProcessedModel[];
 
 if (archBase) {
 	// Build a minimal model config for the alias
@@ -304,12 +306,12 @@ if (archBase) {
 		endpoints: [
 			{
 				type: "openai" as const,
-				baseURL: openaiBaseUrl!,
+				baseURL: openaiBaseUrl,
 			},
 		],
 		// Keep the alias visible
 		unlisted: false,
-	} as any;
+	} as ProcessedModel;
 
 	if (routerMultimodalEnabled) {
 		aliasRaw.multimodal = true;
@@ -318,13 +320,12 @@ if (archBase) {
 
 	const aliasBase = await processModel(aliasRaw);
 	// Create a self-referential ProcessedModel for the router endpoint
-	let aliasModel: any = {};
-	aliasModel = {
+	const aliasModel: ProcessedModel = {
 		...aliasBase,
 		isRouter: true,
 		// getEndpoint uses the router wrapper regardless of the endpoints array
 		getEndpoint: async (): Promise<Endpoint> => makeRouterEndpoint(aliasModel),
-	};
+	} as ProcessedModel;
 
 	// Put alias first
 	decorated = [aliasModel, ...decorated];
diff --git a/src/lib/server/router/arch.ts b/src/lib/server/router/arch.ts
@@ -106,15 +106,15 @@ export async function archSelectRoute(
 		});
 		clearTimeout(to);
 		if (!resp.ok) throw new Error(`arch-router ${resp.status}`);
-		const data: any = await resp.json();
+		const data: { choices: { message: { content: string } }[] } = await resp.json();
 		const text = (data?.choices?.[0]?.message?.content ?? "").toString().trim();
 		const raw = parseRouteName(text);
 
 		const other = config.LLM_ROUTER_OTHER_ROUTE || "casual_conversation";
 		const chosen = raw === "other" ? other : raw || "casual_conversation";
 		const exists = routes.some((r) => r.name === chosen);
 		return { routeName: exists ? chosen : "casual_conversation" };
-	} catch (e: any) {
+	} catch (e) {
 		clearTimeout(to);
 		logger.warn({ err: String(e), traceId }, "arch router selection failed");
 		return { routeName: "arch_router_failure" };
diff --git a/src/lib/server/router/endpoint.ts b/src/lib/server/router/endpoint.ts
@@ -1,4 +1,9 @@
-import type { Endpoint, EndpointParameters, EndpointMessage } from "../endpoints/endpoints";
+import type {
+	Endpoint,
+	EndpointParameters,
+	EndpointMessage,
+	TextGenerationStreamOutputSimplified,
+} from "../endpoints/endpoints";
 import endpoints from "../endpoints/endpoints";
 import type { ProcessedModel } from "../models";
 import { config } from "$lib/server/config";
@@ -17,6 +22,7 @@ function stripReasoningBlocks(text: string): string {
 
 function stripReasoningFromMessage(message: EndpointMessage): EndpointMessage {
 	const { reasoning: _reasoning, ...rest } = message;
+	void _reasoning;
 	const content =
 		typeof message.content === "string" ? stripReasoningBlocks(message.content) : message.content;
 	return {
@@ -47,7 +53,7 @@ export async function makeRouterEndpoint(routerModel: ProcessedModel): Promise<E
 			let modelForCall: ProcessedModel | undefined;
 			try {
 				const mod = await import("../models");
-				const all = (mod as any).models as ProcessedModel[];
+				const all = (mod as { models: ProcessedModel[] }).models;
 				modelForCall = all?.find((m) => m.id === candidateModelId || m.name === candidateModelId);
 			} catch (e) {
 				logger.warn({ err: String(e) }, "[router] failed to load models for candidate lookup");
@@ -75,7 +81,7 @@ export async function makeRouterEndpoint(routerModel: ProcessedModel): Promise<E
 
 		// Yield router metadata for immediate UI display, using the actual candidate
 		async function* metadataThenStream(
-			gen: AsyncGenerator<any>,
+			gen: AsyncGenerator<TextGenerationStreamOutputSimplified>,
 			actualModel: string,
 			selectedRoute: string
 		) {
@@ -84,14 +90,14 @@ export async function makeRouterEndpoint(routerModel: ProcessedModel): Promise<E
 				generated_text: null,
 				details: null,
 				routerMetadata: { route: selectedRoute, model: actualModel },
-			} as any;
+			};
 			for await (const ev of gen) yield ev;
 		}
 
 		async function findFirstMultimodalCandidateId(): Promise<string | undefined> {
 			try {
 				const mod = await import("../models");
-				const all = (mod as any).models as ProcessedModel[];
+				const all = (mod as { models: ProcessedModel[] }).models;
 				const first = all?.find((m) => !m.isRouter && m.multimodal);
 				return first?.id ?? first?.name;
 			} catch (e) {
@@ -132,7 +138,7 @@ export async function makeRouterEndpoint(routerModel: ProcessedModel): Promise<E
 		const fallbackModel = config.LLM_ROUTER_FALLBACK_MODEL || routerModel.id;
 		const { candidates } = resolveRouteModels(routeName, routes, fallbackModel);
 
-		let lastErr: any = undefined;
+		let lastErr: unknown = undefined;
 		for (const candidate of candidates) {
 			try {
 				logger.info({ route: routeName, model: candidate }, "[router] trying candidate");
diff --git a/src/lib/server/textGeneration/reasoning.ts b/src/lib/server/textGeneration/reasoning.ts
@@ -21,9 +21,9 @@ export async function generateSummaryOfReasoning(
 				preprompt: `You are tasked with summarizing the latest reasoning steps. Never describe results of the reasoning, only the process. Remain vague in your summary.
             The text might be incomplete, try your best to summarize it in one very short sentence, starting with a gerund and ending with three points. 
             Example: "Thinking about life...", "Summarizing the results...", "Processing the input..."`,
-			generateSettings: {
-				max_tokens: 50,
-			},
+				generateSettings: {
+					max_tokens: 50,
+				},
 				modelId,
 			})
 		);
diff --git a/src/lib/server/textGeneration/title.ts b/src/lib/server/textGeneration/title.ts
diff --git a/src/lib/utils/marked.ts b/src/lib/utils/marked.ts
diff --git a/src/styles/highlight-js.css b/src/styles/highlight-js.css
