Skip to content

Commit d9f75a4

Browse files
authored
Merge pull request #419 from hubmapconsortium/shirey/doc-chngs-sample-category
Shirey/doc chngs sample category
2 parents e59a474 + 6d5188f commit d9f75a4

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ src/instance/app.cfg
44

55
venv-entity-api
66

7+
#Mac DS Store files
8+
.DS_Store
9+
710
# Ignore copied files
811
docker/entity-api/src
912
docker/entity-api/VERSION

.project

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<projectDescription>
3-
<name>entity-api</name>
3+
<name>hubmap-entity-api</name>
44
<comment></comment>
55
<projects>
66
<project>hubmap-commons</project>

entity-api-spec.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -455,10 +455,18 @@ components:
455455
- snrnaseq
456456
- tissue_lysate
457457
- wgs
458-
description: "A code representing the type of specimen. Must be one of the codes specified in: [tissue sample types](https://github.com/hubmapconsortium/search-api/blob/main/src/search-schema/data/definitions/enums/tissue_sample_types.yaml)"
458+
description: "DEPRECATED: No longer a required field. A code representing the type of specimen. Must be one of the codes specified in: [tissue sample types](https://github.com/hubmapconsortium/search-api/blob/main/src/search-schema/data/definitions/enums/tissue_sample_types.yaml)"
459459
specimen_type_other:
460460
type: string
461461
description: "The user provided sample type if the 'other' sample_type is chosen."
462+
sample_category:
463+
type: string
464+
enum:
465+
- organ
466+
- block
467+
- section
468+
- suspension
469+
description: "A code representing the category of the specimen. Must be one of organ|block|section|suspension. This is a required field. If set to `organ`, the organ property must be provided as well."
462470
protocol_url:
463471
type: string
464472
description: "The protocols.io doi url pointing the protocol under wich the sample was obtained and/or prepared."
@@ -506,7 +514,7 @@ components:
506514
- TR
507515
- UR
508516
- UT
509-
description: "Organ code specifier, only set if sample_type == organ. Valid values found in: [organ types](https://github.com/hubmapconsortium/search-api/blob/main/src/search-schema/data/definitions/enums/organ_types.yaml)"
517+
description: "Organ code specifier, only set if sample_category == organ. Valid values found in: [organ types](https://github.com/hubmapconsortium/search-api/blob/main/src/search-schema/data/definitions/enums/organ_types.yaml)"
510518
organ_other:
511519
type: string
512520
description: The organ type provided by the user if "other" organ type is selected
@@ -1989,7 +1997,7 @@ paths:
19891997
description: the hubmap_id of the unpublished dataset
19901998
organ:
19911999
type: string
1992-
description: the organ type of the sample with specimen_type organ above the unpublished dataset if applicable
2000+
description: the organ type of the sample with sample_category organ above the unpublished dataset if applicable
19932001
organization:
19942002
type: string
19952003
description: the group_name of the unpublished dataset

0 commit comments

Comments
 (0)