Skip to content

Commit add5789

Browse files
replaced several instances in app_neo4j_queries.py get_prov_info() where capitalization was forced through .lower or
.capitalize now use the neo4j string function toUpper().
1 parent 4954894 commit add5789

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

src/app_neo4j_queries.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -943,24 +943,21 @@ def get_prov_info(neo4j_driver, param_dict):
943943
first_param = True
944944
if 'group_uuid' in param_dict:
945945
first_param = False
946-
group_uuid_query_string = f" WHERE ds.group_uuid = '{param_dict['group_uuid']}'"
946+
group_uuid_query_string = f" WHERE toUpper(ds.group_uuid) = '{param_dict['group_uuid'].upper()}'"
947947
if 'organ' in param_dict:
948948
organ_query_string = 'MATCH'
949-
organ_where_clause = f", organ: '{param_dict['organ'].upper()}'"
949+
# organ_where_clause = f", organ: '{param_dict['organ'].upper()}'"
950+
organ_where_clause = f" WHERE toUPPER(organ.organ) = '{param_dict['organ'].upper()}'"
950951
if 'has_rui_info' in param_dict:
951952
rui_info_query_string = 'MATCH (ds)<-[*]-(ruiSample:Sample)'
952953
if param_dict['has_rui_info'].lower() == 'false':
953954
rui_info_query_string = 'MATCH (ds:Dataset)'
954955
rui_info_where_clause = "WHERE NOT EXISTS {MATCH (ds)<-[*]-(ruiSample:Sample) WHERE NOT ruiSample.rui_location IS NULL AND NOT TRIM(ruiSample.rui_location) = ''} MATCH (ds)<-[*]-(ruiSample:Sample)"
955956
if 'dataset_status' in param_dict:
956957
if first_param:
957-
dataset_status_query_string = f" WHERE ds.status = '{param_dict['dataset_status'].capitalize()}'"
958-
if param_dict['dataset_status'].lower() == "qa":
959-
dataset_status_query_string = f" WHERE ds.status = 'QA'"
958+
dataset_status_query_string = f" WHERE toUpper(ds.status) = '{param_dict['dataset_status'].upper()}'"
960959
else:
961-
dataset_status_query_string = f" AND ds.status = '{param_dict['dataset_status'].capitalize()}'"
962-
if param_dict['dataset_status'].lower() == "qa":
963-
dataset_status_query_string = f" AND ds.status = 'QA'"
960+
dataset_status_query_string = f" AND toUpper(ds.status) = '{param_dict['dataset_status'].upper()}'"
964961
query = (f"MATCH (ds:Dataset)<-[:ACTIVITY_OUTPUT]-(a)<-[:ACTIVITY_INPUT]-(firstSample:Sample)<-[*]-(donor:Donor)"
965962
f"{group_uuid_query_string}"
966963
f"{dataset_status_query_string}"
@@ -971,7 +968,8 @@ def get_prov_info(neo4j_driver, param_dict):
971968
f" {rui_info_query_string}"
972969
f" {rui_info_where_clause}"
973970
f" WITH ds, FIRSTSAMPLE, DONOR, METASAMPLE, collect(distinct ruiSample) as RUISAMPLE"
974-
f" {organ_query_string} (donor)-[:ACTIVITY_INPUT]->(oa)-[:ACTIVITY_OUTPUT]->(organ:Sample {{specimen_type:'organ'{organ_where_clause}}})-[*]->(ds)"
971+
f" {organ_query_string} (donor)-[:ACTIVITY_INPUT]->(oa)-[:ACTIVITY_OUTPUT]->(organ:Sample {{specimen_type:'organ'}})-[*]->(ds)"
972+
f" {organ_where_clause}"
975973
f" WITH ds, FIRSTSAMPLE, DONOR, METASAMPLE, RUISAMPLE, COLLECT(DISTINCT organ) AS ORGAN "
976974
f" OPTIONAL MATCH (ds)-[:ACTIVITY_INPUT]->(a3)-[:ACTIVITY_OUTPUT]->(processed_dataset:Dataset)"
977975
f" WITH ds, FIRSTSAMPLE, DONOR, METASAMPLE, RUISAMPLE, ORGAN, COLLECT(distinct processed_dataset) AS PROCESSED_DATASET"

0 commit comments

Comments
 (0)