Skip to content

Commit 4e06950

Browse files
authored
Merge pull request #322 from hubmapconsortium/test-release
v2.0.28 release - additional
2 parents 8b94464 + 7541c3d commit 4e06950

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/schema/provenance_schema.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ ENTITIES:
197197
transient: true
198198
generated: true
199199
description: "The datasets that are contained in the collection."
200+
# A few time-consuming properties (with read triggers) of each dataset are excluded
200201
on_read_trigger: get_collection_datasets
201202

202203
############################################# Dataset #############################################
@@ -766,11 +767,10 @@ ENTITIES:
766767
description: 'List of datasets to remove from a Upload. Provide as a json array of the dataset uuids like: ["232934234234234234234270c0ea6c51d604a850558ef2247d0b4", "230948203482234234234a57bfe9c056d08a0f8e6cd612baa3bfa"]'
767768
# Use after_update_trigger instead of before_update_trigger since we are not updating this property
768769
after_update_trigger: unlink_datasets_from_upload
769-
# Different from the handling of Collection (only returns dataset_uuids)
770770
datasets:
771771
type: list
772772
generated: true # Disallow user input from request json when being created
773773
transient: true
774774
description: "The datasets that are contained in this Upload."
775-
# A few time-consuming read triggers are excluded
775+
# A few time-consuming properties (with read triggers) of each dataset are excluded
776776
on_read_trigger: get_upload_datasets

src/schema/schema_triggers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -702,9 +702,9 @@ def get_dataset_collections(property_key, normalized_type, user_token, existing_
702702
# Get back the list of collection dicts
703703
collections_list = schema_neo4j_queries.get_dataset_collections(schema_manager.get_neo4j_driver_instance(), existing_data_dict['uuid'])
704704

705-
# Exclude dataset_uuids from each resulting collection
705+
# Exclude datasets from each resulting collection
706706
# We don't want to show too much nested information
707-
properties_to_skip = ['dataset_uuids']
707+
properties_to_skip = ['datasets']
708708
complete_entities_list = schema_manager.get_complete_entities_list(user_token, collections_list, properties_to_skip)
709709

710710
return property_key, schema_manager.normalize_entities_list_for_response(complete_entities_list)
@@ -740,9 +740,9 @@ def get_dataset_upload(property_key, normalized_type, user_token, existing_data_
740740
upload_dict = schema_neo4j_queries.get_dataset_upload(schema_manager.get_neo4j_driver_instance(), existing_data_dict['uuid'])
741741

742742
if upload_dict:
743-
# Exclude dataset_uuids from each resulting Upload
743+
# Exclude datasets from each resulting Upload
744744
# We don't want to show too much nested information
745-
properties_to_skip = ['dataset_uuids']
745+
properties_to_skip = ['datasets']
746746
complete_upload_dict = schema_manager.get_complete_entity_result(user_token, upload_dict, properties_to_skip)
747747
return_dict = schema_manager.normalize_entity_result_for_response(complete_upload_dict)
748748

0 commit comments

Comments
 (0)