Removed an unecessary check for entity type. Removed unecessary formatting of uuids list. Added missing parameter to function comment block

Author: DerekFurstPitt

src/schema/schema_neo4j_queries.py

@@ -122,16 +122,17 @@ def get_entity(neo4j_driver, uuid):
     The neo4j database connection pool
 direct_ancestor_uuids : list
     List of the uuids to be filtered
+entity_type : string
+    The entity to be excluded
 
 Returns
 -------
 dict
     A dictionary of entity uuids that don't pass the filter, grouped by entity_type
 """
 def filter_ancestors_by_type(neo4j_driver, direct_ancestor_uuids, entity_type):
-    uuids_str = ", ".join([f'"{uuid}"' for uuid in direct_ancestor_uuids])
     query = (f"MATCH (e:Entity) "
-             f"WHERE e.uuid in [{uuids_str}] AND toLower(e.entity_type) <> '{entity_type.lower()}' "
+             f"WHERE e.uuid in {direct_ancestor_uuids} AND toLower(e.entity_type) <> '{entity_type.lower()}' "
              f"RETURN e.entity_type AS entity_type, collect(e.uuid) AS uuids")
     logger.info("======filter_ancestors_by_type======")
     logger.info(query)

src/schema/schema_validators.py

@@ -586,8 +586,6 @@ def validate_creation_action(property_key, normalized_entity_type, request, exis
     if creation_action == '':
         raise ValueError(f"The property {property_key} cannot be empty, when specified.")
     if creation_action == 'external process':
-        if normalized_entity_type.lower() != "dataset":
-            raise ValueError(f"Only datasets are allowed to have creation_action of 'external_process'. Provided entity is a {normalized_entity_type}")
         direct_ancestor_uuids = new_data_dict.get('direct_ancestor_uuids')
         entity_types_dict = schema_neo4j_queries.filter_ancestors_by_type(schema_manager.get_neo4j_driver_instance(), direct_ancestor_uuids, "dataset")
         if entity_types_dict: