Skip to content

Commit 1547762

Browse files
authored
Merge pull request #240 from hubmapconsortium/Derek-Furst/datasets-feature-revisions
Fixed an issue in datasets/<id>/revisions. Query parameter was not im…
2 parents 8d3f29b + bee960b commit 1547762

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/app.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2053,10 +2053,11 @@ def retract_dataset(id):
20532053
@app.route('/datasets/<id>/revisions', methods=['GET'])
20542054
def get_revisions_list(id):
20552055
# By default, do not return dataset. Only return dataset if return_dataset is true
2056-
include_dataset = False
2057-
args = request.args
2058-
if "include_dataset" in args and args['include_dataset'] and type(args['include_dataset']) is bool:
2059-
include_dataset = args['include_dataset']
2056+
show_dataset = False
2057+
if bool(request.args):
2058+
include_dataset = request.args.get('include_dataset')
2059+
if (include_dataset is not None) and (include_dataset.lower() == 'true'):
2060+
show_dataset = True
20602061
# Token is not required, but if an invalid token provided,
20612062
# we need to tell the client with a 401 error
20622063
validate_token_if_auth_header_exists(request)
@@ -2111,10 +2112,10 @@ def get_revisions_list(id):
21112112
for revision in normalized_revisions_list:
21122113
result = {
21132114
'revision_number': revision_number,
2114-
'dataset_uuid': revision['uuid'],
2115+
'dataset_uuid': revision['uuid']
21152116
}
2116-
if include_dataset is True:
2117-
result['dataset']: revision
2117+
if show_dataset:
2118+
result['dataset'] = revision
21182119
results.append(result)
21192120
revision_number -= 1
21202121

0 commit comments

Comments
 (0)