From acf53ec7bbc26ea59142b29235946a1a1508be40 Mon Sep 17 00:00:00 2001 From: vyckou Date: Fri, 11 Sep 2026 17:44:13 +0300 Subject: [PATCH] Logline bugfix in GitHubClient.java When logging is set to FINER on org.kohsuke.github.GitHubClient class, expected behavior should be ``` FINE (2a8c) GitHub API request: GET https://api.github.com/repos/my-org/my-repo/pulls/123 FINER (2a8c) GitHub API response: https://api.github.com/repos/my-org/my-repo/pulls/123 200 ``` but instead we are getting ``` FINE (2a8c) GitHub API request: GET https://api.github.com/repos/my-org/my-repo/pulls/123 FINER (2a8c) GitHub API response: https://api.github.com/repos/my-org/my-repo/pulls/123 ``` response log line silently eats up response status code --- src/main/java/org/kohsuke/github/GitHubClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GitHubClient.java b/src/main/java/org/kohsuke/github/GitHubClient.java index 3b8c55c4ab..9077c91a43 100644 --- a/src/main/java/org/kohsuke/github/GitHubClient.java +++ b/src/main/java/org/kohsuke/github/GitHubClient.java @@ -823,7 +823,7 @@ private void logRequest(@Nonnull final GitHubConnectorRequest request) { private void logResponse(@Nonnull final GitHubConnectorResponse response) { LOGGER.log(FINER, () -> { - return String.format("(%s) GitHub API response: %s", + return String.format("(%s) GitHub API response: %s %d", sendRequestTraceId.get(), response.request().url().toString(), response.statusCode());