Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue - just a question #12

Closed
cyppe opened this issue Jun 3, 2024 · 3 comments
Closed

Not an issue - just a question #12

cyppe opened this issue Jun 3, 2024 · 3 comments

Comments

@cyppe
Copy link
Contributor

cyppe commented Jun 3, 2024

Hello!

That is your thoughts about possibility to go back to using krowinski/php-mysql-replication library again instead of the moln/php-mysql-replication fork?

The moln fork works great so no big deal. But it seems like moln is falling behind as krowinski/php-mysql-replication seems to be better maintained last months and also have a few new features like krowinski/php-mysql-replication#112 (rows query event).

I don't know exactly what feature was missing/broken in krowinski's library that made you switch to moln, so before I start looking into it maybe you have some information to share. Maybe you can easily see if the problems is resolved in the original package now so laravel-trigger could use it again?

Just afraid moln library might be abandoned as I really love your laravel-trigger package :)

So please share your thoughts, or if you prefer to stay with Moln that would also be interesting to know. I can probably also help with something if needed.

@huangdijia
Copy link
Owner

https://github.com/krowinski/php-mysql-replication/pull/104/files

Before because symfony dependence conflict, after the official adjustment, you can help mention a PR change back?

@cyppe
Copy link
Contributor Author

cyppe commented Jun 6, 2024

Aha got it!

Yes I can help, but it seems like you were very quick and already tried it? But I can at least test 6.x branch in my projects and see if it works as expected.

@huangdijia
Copy link
Owner

Aha got it!

Yes I can help, but it seems like you were very quick and already tried it? But I can at least test 6.x branch in my projects and see if it works as expected.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants