Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver '76 icon seems to be decoded wrong #16822

Closed
hrydgard opened this issue Jan 20, 2023 · 3 comments · Fixed by #20033
Closed

Driver '76 icon seems to be decoded wrong #16822

hrydgard opened this issue Jan 20, 2023 · 3 comments · Fixed by #20033
Labels
User Interface PPSSPP's own user interface / UX
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Jan 20, 2023

We're not the only ones who decode it as all black though:

image

ICON0

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jan 20, 2023
@unknownbrackets
Copy link
Collaborator

I tried a quick recompress of the PNG which generated this image (same pixels/RGB values, just adjusted compression):
driver76b

Looking at the metadata, the gamma value is pretty different. If I remove the gAMA chunk only, it similarly looks better:
driver76-gama

I guess probably we should be ignoring the gAMA chunk here? Its current value is 22727, which is what causes things to be darker.

-[Unknown]

@hrydgard
Copy link
Owner Author

Nice, yeah, indeed seems very likely that the PSP simply ignores the gamma block entirely, and thus we should do the same when displaying these. Don't know if there's an option for it for the png reader we use.

@hrydgard
Copy link
Owner Author

hrydgard commented Jan 25, 2023

Doesn't look like there's a way to override gamma in the simplified API that we use (png_image_begin_read_from_memory). We'd have to switch to using the absolutely awful full API to access the gamma modification functions..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants