-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the volume settings less confusing #18888
Comments
Not that it doesn't require changes, but a piece of history: It probably needs to be divided to:
And maybe have a global volume on top of them all to keep it simple if there are still devices lacking volume control. Currently there's really no clear separation, just new things got new volume sliders without taking into account of what existed before and it got a bit messy. |
I understand the history and I've come pretty much to the same conclusion as you LunaMoo. In addition there could also be a tick for Advanced volume settings as unknown described here #7376 (comment) |
For devices like the steamdeck, where volume is controlled mainly by the OS. The PSP should be locked so it always uses the greatest range, but a UI volume slider and mute(to replace enable/disable) would be nice. So "game" volume should have a slider and a 3 position for max/adjusted/mute, perhaps just a slider with snap-to slots at the ends for these. |
Yeah, this indeeds needs cleanup, along the lines of LunaMoo's proposal |
I'm doing some changes here now:
Also considering adding a lot more volume steps, 10 is quite coarse, even on a logarithmic scale. This will require renaming the ini keys of course (though can upgrade old settings). However, I feel Achievement Volume should maybe also be a multiplier on top of Game Volume rather than part of UI sounds? While it's produced independently from the game, it does happen in response to an in-game event, so it feels like in-game audio. |
A bit of late feedback. The improvements on the scaling are pretty good! 🚀 So if possible I'd recommend adding a line of text underneath each slider in the popup window where this would help. I.e. For UI sounds, having the tickbox is redundant since setting UI volume to 0 mutes it. As for Achievement volume, if you're gonna keep it independent of Game volume, then consider moving it to the UI sounds section. Lastly, having Game volume default to 100 is a bit extreme. 📢 I hope this helps. |
Yeah, some indicator of how the relative thing works like that might be good. Not sure about keeping the % signs.. The tickbox is actually not redundant since "UI Sounds" only affects the navigation sounds, not the "preview audio" of games (when selected with keyboard/gamepad or when in the info dialog). Not really sure how to solve that properly, but I guess maybe the checkbox should be changed into a "Navigation sounds" slider, separate from the preview audio? Not sure. Well, games don't often actually reach 100% so it's not so extreme actually. |
Yes, that's what I implied. |
I might do some more improvements for 1.19. At least the tricky part of rescaling the parameters is done. So, re-opening and renaming the issue. |
The "Global volume" setting doesn't affect UI volume so it shouldn't be labeled as global, but rather "Game volume" or something.
On another note, the preview volume IS affected by the aforementioned setting, but I feel like this should be handled by a separate "UI volume" setting, which is something we don't have. See also #18865
The text was updated successfully, but these errors were encountered: