Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the volume settings less confusing #18888

Open
NABN00B opened this issue Feb 24, 2024 · 9 comments · Fixed by #19969
Open

Make the volume settings less confusing #18888

NABN00B opened this issue Feb 24, 2024 · 9 comments · Fixed by #19969
Labels
Audio User Interface PPSSPP's own user interface / UX
Milestone

Comments

@NABN00B
Copy link
Contributor

NABN00B commented Feb 24, 2024

The "Global volume" setting doesn't affect UI volume so it shouldn't be labeled as global, but rather "Game volume" or something.

On another note, the preview volume IS affected by the aforementioned setting, but I feel like this should be handled by a separate "UI volume" setting, which is something we don't have. See also #18865

@LunaMoo
Copy link
Collaborator

LunaMoo commented Feb 25, 2024

Not that it doesn't require changes, but a piece of history:
this was called global volume, because it was needed for devices that doesn't have volume control and also, because in the past it had additional options for SAS and ATRAC/MP3 audio.
They were called differently I guess something alike "music" and "effects" don't remember exactly, but since they weren't doing what they were called(which was just a common use, but all games are different), people were crying about the setting not affecting what they wanted and as such the additional options got removed.

It probably needs to be divided to:

  • In-game volume with a sub-option of reverb volume (both prefferably as game specific settings),
  • UI volume with a sub-option of achievements volume (through maybe those could just be normalized if the option exist purely because the achievements were too loud compared to other UI sounds) and possibly separate volume for preview songs.

And maybe have a global volume on top of them all to keep it simple if there are still devices lacking volume control.

Currently there's really no clear separation, just new things got new volume sliders without taking into account of what existed before and it got a bit messy.

@NABN00B
Copy link
Contributor Author

NABN00B commented Feb 25, 2024

I understand the history and I've come pretty much to the same conclusion as you LunaMoo.

In addition there could also be a tick for Advanced volume settings as unknown described here #7376 (comment)

@cheako
Copy link

cheako commented Feb 26, 2024

For devices like the steamdeck, where volume is controlled mainly by the OS. The PSP should be locked so it always uses the greatest range, but a UI volume slider and mute(to replace enable/disable) would be nice. So "game" volume should have a slider and a 3 position for max/adjusted/mute, perhaps just a slider with snap-to slots at the ends for these.

@hrydgard hrydgard added this to the v1.18.0 milestone Feb 27, 2024
@hrydgard
Copy link
Owner

Yeah, this indeeds needs cleanup, along the lines of LunaMoo's proposal

@hrydgard hrydgard modified the milestones: v1.18.0, v1.19.0 Jul 19, 2024
@hrydgard
Copy link
Owner

I'm doing some changes here now:

  • Renaming "Global volume" to "Game volume", and making Alt Speed Volume a multiplier on top of that (so it's never louder).
  • Adding UI volume which will control UI sounds (if enabled) and preview-music playback.

Also considering adding a lot more volume steps, 10 is quite coarse, even on a logarithmic scale. This will require renaming the ini keys of course (though can upgrade old settings).

However, I feel Achievement Volume should maybe also be a multiplier on top of Game Volume rather than part of UI sounds? While it's produced independently from the game, it does happen in response to an in-game event, so it feels like in-game audio.

@NABN00B
Copy link
Contributor Author

NABN00B commented Feb 21, 2025

A bit of late feedback. The improvements on the scaling are pretty good! 🚀
However, when seeing it for the first time it's slightly confusing seeing 4 percentages stacked on top of each other. It isn't hinted which volume is dependent on which (or why Reverb volume has a different scale).

So if possible I'd recommend adding a line of text underneath each slider in the popup window where this would help. I.e. Relative to / Multiplier of Game volume when for Alt speed volume, an explanation for Reverb volume etc. (Also a minor thing but the sliders don't show the % metric like Button opacity or the others.)

For UI sounds, having the tickbox is redundant since setting UI volume to 0 mutes it.
I think we should have a separate option for the preview songs like LunaMoo has suggested. Although the loudness of them vary from game to game, being able to lower them in general (or mute them independently of UI SFX) would be an improvement.

As for Achievement volume, if you're gonna keep it independent of Game volume, then consider moving it to the UI sounds section.

Lastly, having Game volume default to 100 is a bit extreme. 📢

I hope this helps.

@hrydgard
Copy link
Owner

hrydgard commented Feb 21, 2025

Yeah, some indicator of how the relative thing works like that might be good. Not sure about keeping the % signs..

The tickbox is actually not redundant since "UI Sounds" only affects the navigation sounds, not the "preview audio" of games (when selected with keyboard/gamepad or when in the info dialog). Not really sure how to solve that properly, but I guess maybe the checkbox should be changed into a "Navigation sounds" slider, separate from the preview audio? Not sure.

Well, games don't often actually reach 100% so it's not so extreme actually.

@NABN00B
Copy link
Contributor Author

NABN00B commented Feb 21, 2025

Not really sure how to solve that properly, but I guess maybe the checkbox should be changed into a "Navigation sounds" slider, separate from the preview audio? Not sure.

Yes, that's what I implied.

@hrydgard
Copy link
Owner

I might do some more improvements for 1.19. At least the tricky part of rescaling the parameters is done. So, re-opening and renaming the issue.

@hrydgard hrydgard reopened this Feb 21, 2025
@hrydgard hrydgard changed the title "Global volume" string is confusing Make the volume settings less confusing Feb 21, 2025
@hrydgard hrydgard added User Interface PPSSPP's own user interface / UX Audio labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants