Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
EmanuelJr
requested review from
matheusfrancisco,
mtmr0x,
p3rotto,
racerxdl,
rogefm and
sandromello
This comment was marked as outdated.
This comment was marked as outdated.
p3rotto
approved these changes
Mar 23, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
matheusfrancisco
approved these changes
Mar 23, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-9912d79 |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-96ace14 |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-b3e3e8b |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-305644f |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-1de404b |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-3c4822e |
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
📋 API ChangelogAPI Changelog unknown vs. unknownAPI ChangesGET /access-requests/rules
POST /access-requests/rules
GET /access-requests/rules/{name}
PUT /access-requests/rules/{name}
GET /attributes
POST /attributes
DELETE /attributes/{name}
GET /attributes/{name}
PUT /attributes/{name}
GET /audit/logs
GET /connections
POST /connections
GET /connections/{nameOrID}
PATCH /connections/{nameOrID}
PUT /connections/{nameOrID}
GET /datamasking-rules
POST /datamasking-rules
GET /datamasking-rules/{id}
PUT /datamasking-rules/{id}
GET /guardrails
POST /guardrails
GET /guardrails/{id}
PUT /guardrails/{id}
GET /sessions/{session_id}/rdp-frames
|
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-724524f |
Contributor
|
✅ Build Completed with Success, Version=1319.0.0-123ffdb |
racerxdl
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Implements a new Attributes management system that acts as a grouping mechanism to associate connections with guardrail rules, access request rules, and data masking rules. Instead of directly linking rules to connections, attributes serve as an intermediary layer enabling more flexible and reusable policy assignments.
🔗 Related Issue
🚀 Type of Change
📋 Changes Made
GET /attributes,GET /attributes/:name,POST /attributes,PUT /attributes/:name,DELETE /attributes/:name) with admin-only accessAttribute,ConnectionAttribute,AccessRequestRuleAttribute,GuardrailRuleAttribute, andDatamaskingRuleAttributeGORM models with support for upsert, list (paginated + searchable), get, and delete operations000065_attributescreatingattributes,connections_attributes,access_request_rules_attributes,guardrail_rules_attributes, anddatamasking_rules_attributesjunction tables with appropriate foreign key constraintsservicespackage (guardrails.go,datamasking.go) to abstract attribute-aware rule resolution, falling back to direct connection-based lookup when no attributes are foundtransport/client.go,transport/extensions/extension.go,api/session/session.go, and the access request interceptor to use the new services layer🧪 Testing
Test Configuration:
Tests performed:
📸 Screenshots (if applicable)
N/A
✅ Checklist
📄 Additional Notes
The attributes system is additive and backward-compatible. If a connection has no attributes assigned, all rule lookups fall back to the existing direct connection-based behavior, ensuring no regression for existing configurations.