Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] Some brightness values cannot be parsed #2799

Closed
Niklas04 opened this issue Dec 29, 2024 · 5 comments
Closed

[de] Some brightness values cannot be parsed #2799

Niklas04 opened this issue Dec 29, 2024 · 5 comments

Comments

@Niklas04
Copy link

Niklas04 commented Dec 29, 2024

Hello All,

I currently have the issue of some light brightness values not parsed in German.

This sentence for example cannot be parsed:
Stelle die Helligkeit von der Schlafzimmerlampe auf siebzig %

This sentence can be parsed:
Stelle die Helligkeit von der Schlafzimmerlampe auf 70 %

It seems like only numbers written in words cannot be parsed. However, this is not the case for all numbers - 10, 11, 75 seem to work.

I adapted the tests in light_HassLightSet.yaml, but was not able to figure out what the issue is. Please find the new test cases attached as txt-file.

For the English language, this seems to be working.
light_HassLightSet.txt

Edit:
Please find here an output of the Developer-Tools with another example:
Lampe Wohnzimmer Vorne auf siebzig Prozent
Sprache: Deutsch (de)
intent:
name: HassLightSet
slots:
name: Lampe Wohnzimmer Vorne
details:
name:
name: name
value: Lampe Wohnzimmer Vorne
text: Lampe Wohnzimmer Vorne
targets: {}
match: false
sentence_template: [ (auf|zu)] [ dimmen]
unmatched_slots:
brightness: 'siebzig '
source: builtin

@Jeffx59
Copy link
Contributor

Jeffx59 commented Dec 30, 2024

Hi,
I confirm my previous post #2717 and this new one #2799.
Brightness command with one word numbers written in letters don't work in french, and apparently in german language too.
No problem with english language.
Regards

@mib1185
Copy link
Contributor

mib1185 commented Dec 30, 2024

This should be solved by rhasspy/unicode-rbnf#6

@Niklas04
Copy link
Author

This should be solved by rhasspy/unicode-rbnf#6

With these changes it seems to work - Thank you

@mib1185
Copy link
Contributor

mib1185 commented Jan 1, 2025

This issue should be solved with home-assistant/core#134359 which will be released in 2025.1.0 on Friday.

@mib1185 mib1185 closed this as completed Jan 1, 2025
@Niklas04
Copy link
Author

Niklas04 commented Jan 1, 2025

Yeah works great with unicode_rbnf version 2.2.0 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants