Order automation devices in pickers based on automation usage #27477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…origualada/frontend into order-automation-devices-in-pickers
bramkragten
reviewed
Oct 13, 2025
| Object.values(this._configSubscriptions).forEach((sub) => | ||
| sub(this._config) | ||
| ); | ||
| const ctx = buildAutomationLocalContext( |
Member
There was a problem hiding this comment.
I would like to prevent this from re-creating everything when the automation changes, as it will trigger the other memoized functions to also recalculate. Can we make sure to only update those parts that actually changed? So if no devices changed, we don't recreate used.devices.
Contributor
Author
There was a problem hiding this comment.
I added a signature to the context that we can compare on change updates to not update the context object.
victorigualada
commented
Oct 13, 2025
|
|
||
| const suggestedPrefix = suggestedDevices?.includes(device.id) | ||
| ? "0|" | ||
| : "1|"; |
Contributor
Author
There was a problem hiding this comment.
@bramkragten This is hacky but I didn't want to increase the scope of the PR nor know how you would approach an alternative. In my mind this would be replaced by a proper grouping like “Suggested” and “All devices” or something similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds the ability to reorder the device picker in automations based on the automation context. My idea was to follow the locality principle to allow faster automation creation.
It adds a Lit context to store the automation devices, entities and areas in order to pass down those values to the pickers so the lists can be reordered based on them.
I added a bigger context schema than needed for this PR just to discuss how it could be extended. This is intended as a minimal feature.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: