Skip to content

Conversation

@Edsol
Copy link

@Edsol Edsol commented Sep 5, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

camera_view: auto
alert_classes:
  - motion
  - moisture
sensor_classes:
  - temperature
  - humidity
display_type: camera
features_position: bottom
type: area
area: giardino_posteriore
color: ""
vertical: false
camera_entity: camera.posteriore2

Additional information

The card area displays the first camera by default.

Once the camera entity search has been added for each area, they will be displayed in a new dedicated field so that you can choose which camera to view.

immagine
  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The card area displays the first camera by default.

Once the camera entity search has been added for each area, they will be displayed in a new dedicated field so that you can choose which camera to view.

home-assistant[bot]

This comment was marked as resolved.

@home-assistant home-assistant bot marked this pull request as draft September 5, 2025 09:18
@home-assistant

This comment was marked as resolved.

home-assistant[bot]

This comment was marked as resolved.

@Edsol Edsol marked this pull request as ready for review September 5, 2025 09:35
@home-assistant home-assistant bot dismissed stale reviews from themself September 5, 2025 09:35

Stale

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Edsol

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft September 5, 2025 10:24
@Edsol Edsol marked this pull request as ready for review September 5, 2025 10:34
@silamon silamon removed the cla-error label Sep 5, 2025
@MindFreeze MindFreeze added the Needs UX Pull requests requiring a review from the Home Assistant design team label Sep 7, 2025
@MindFreeze
Copy link
Member

Not sure if this has to be set on the area itself, like temp & humidity. Needs input from the UX team

@bramkragten bramkragten removed the Needs UX Pull requests requiring a review from the Home Assistant design team label Sep 8, 2025
@bramkragten
Copy link
Member

Approved by UX

Copy link
Member

@timmo001 timmo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options should use the friendly entity names and IMO the default camera should be kept (and selected in the options / auto as the default value)

@home-assistant home-assistant bot marked this pull request as draft September 8, 2025 11:53
@Edsol Edsol marked this pull request as ready for review September 18, 2025 06:37
@home-assistant home-assistant bot requested a review from timmo001 September 18, 2025 06:37
// entities: HomeAssistant["entities"],
hass: any,
areaId: string
): string[] | undefined => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really return undefined does it?

Comment on lines +185 to +186
include_entities: cameraEntities,
filter: [{ domain: "camera" }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need a domain filter if you've already whitelisted the list of cameras?

@bramkragten bramkragten marked this pull request as draft October 29, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants