-
Notifications
You must be signed in to change notification settings - Fork 3.4k
possibility to choose the camera in case of multiple entities #26892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Not sure if this has to be set on the area itself, like temp & humidity. Needs input from the UX team |
|
Approved by UX |
src/panels/lovelace/editor/config-elements/hui-area-card-editor.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/config-elements/hui-area-card-editor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The options should use the friendly entity names and IMO the default camera should be kept (and selected in the options / auto as the default value)
src/panels/lovelace/editor/config-elements/hui-area-card-editor.ts
Outdated
Show resolved
Hide resolved
| // entities: HomeAssistant["entities"], | ||
| hass: any, | ||
| areaId: string | ||
| ): string[] | undefined => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really return undefined does it?
| include_entities: cameraEntities, | ||
| filter: [{ domain: "camera" }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need a domain filter if you've already whitelisted the list of cameras?
Breaking change
Proposed change
Type of change
Example configuration
Additional information
The card area displays the first camera by default.
Once the camera entity search has been added for each area, they will be displayed in a new dedicated field so that you can choose which camera to view.
Checklist
If user exposed functionality or configuration variables are added/changed:
The card area displays the first camera by default.
Once the camera entity search has been added for each area, they will be displayed in a new dedicated field so that you can choose which camera to view.