From bcbc36b5114b3580242b14a3d9391b972bce91b8 Mon Sep 17 00:00:00 2001 From: Tom Ligier Date: Thu, 1 Oct 2020 22:58:06 +0200 Subject: [PATCH 1/2] FIX #26: MISCALCULATING MIN AND MAX BARPLOT VALUES Calculate min and max values according to https://www.data-to-viz.com/caveat/boxplot.html. Previous values were calculated as if there would always be outliers values. --- graph/boxplot_basic.html | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/graph/boxplot_basic.html b/graph/boxplot_basic.html index 8779661..3a67b00 100644 --- a/graph/boxplot_basic.html +++ b/graph/boxplot_basic.html @@ -219,12 +219,16 @@
Steps:
// Compute summary statistics used for the box: var data_sorted = data.sort(d3.ascending) +var min_data = data_sorted[0] +var max_data = data_sorted[data_sorted.length - 1] var q1 = d3.quantile(data_sorted, .25) var median = d3.quantile(data_sorted, .5) var q3 = d3.quantile(data_sorted, .75) var interQuantileRange = q3 - q1 -var min = q1 - 1.5 * interQuantileRange -var max = q1 + 1.5 * interQuantileRange +var lowerExtremeValue = q1 - 1.5 * interQuantileRange +var upperExtremeValue = q3 + 1.5 * interQuantileRange +var min = d3.max([min_data, lowerExtremeValue]) +var max = d3.min([max_data, upperExtremeValue]) // Show the Y scale var y = d3.scaleLinear() From f64f8882d861b86651b7f8efba09c3c0cfd40675 Mon Sep 17 00:00:00 2001 From: Tom Ligier Date: Thu, 1 Oct 2020 23:22:17 +0200 Subject: [PATCH 2/2] FIX #4 : WRONG DOCUMENTATION Documentation changed to correspond to the "Categorical color scale" example. --- graph/custom_color.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graph/custom_color.html b/graph/custom_color.html index 5897126..810ca59 100644 --- a/graph/custom_color.html +++ b/graph/custom_color.html @@ -275,7 +275,7 @@

Categorical color scale

You have a several groups, and want to attribute a specific color to each group. Several way to build this scale