Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths from workspace root in wasm_error! messages #139

Open
mattyg opened this issue Dec 31, 2024 · 1 comment
Open

Use relative paths from workspace root in wasm_error! messages #139

mattyg opened this issue Dec 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mattyg
Copy link
Member

mattyg commented Dec 31, 2024

Currently the wasm_error! macro uses file!() macro to include the path to file where the error occured. Because this is generated at compile time, it shows the path from the machine where the wasm was compiled.

This can lead to confusing error messages as consumers will see a filesystem they don't recognize (i.e. (/home/matt/Projects/Holochain/...). They may not be sure if something is not working properly, or maybe an incorrect path is the source of their error. This came up while supporting development of Volla Messages.

We should investigate if we can use relative paths from the workspace root

@mattyg mattyg added the enhancement New feature or request label Dec 31, 2024
@mattyg mattyg added this to Holochain Dec 31, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Holochain Dec 31, 2024
@mattyg mattyg moved this from Backlog to Ready for refinement in Holochain Dec 31, 2024
@mattyg mattyg self-assigned this Dec 31, 2024
@mattyg
Copy link
Member Author

mattyg commented Jan 1, 2025

It does look like WasmError file paths are relative (see #140). Will need to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for refinement
Development

No branches or pull requests

1 participant