add case creation support

Author: aktaskaan

src/aat/resources/features/F-1015 - Start Case Event TTL/F-1015.feature

@@ -24,7 +24,7 @@ Feature: F-1015: Update Case - Start Case Event - Update Code for TTL
     And   the response has all other details as expected
     And   the response [contains the TTL.SystemTTL for the case, that has been set to 20 days from today]
 
-  @S-1015.1.repeat 
+  @S-1015.1.repeat
   Scenario: TTLIncrement is set to "20" for the Case Event and Start Event is invoked on v1_external#/case-details-endpoint/startEventForCaseworkerUsingGET
     Given a user with [an active profile in CCD],
     And   a successful call [to create a case] as in [F-1015_CreateCasePreRequisiteCaseworker_noTTL]
@@ -461,7 +461,7 @@ Feature: F-1015: Update Case - Start Case Event - Update Code for TTL
     And   the request [has a TTLIncrement of 20 days configured]
     And   the request [is configured to trigger an About to Start callback that changes TTL.OverrideTTL]
     And   it is submitted to call the [Start event creation process to update a case (v1_int caseworker)] operation of [CCD Data Store]
-    
+
     Then  a negative response is received
     And   the response has all other details as expected
     And   the response [contains the error message indicating unauthorised change to the TTL values]

src/aat/resources/features/F-1017 - Validate Event to Update TTL/F-1017.feature

@@ -252,7 +252,7 @@ Feature: F-1017: Validate Event to Update TTL
 #  #CCD-3535 & #CCD-3562: Trigger a mid-event callback that makes permitted changes to the TTL values: v1_external#/citizen/case-details-endpoint/validateCaseDetailsUsingPOST_1
 #-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 
-    @S-1017.21 #CCD-3535
+    @S-1017.21 @Smoke #CCD-3535
     Scenario: Trigger a mid event callback that changes TTL.Suspended (null -> missing). Mid Event is invoked on v1_external#/citizen/case-details-endpoint/validateCaseDetailsUsingPOST_1
       Given a user with [an active profile in CCD]
         And a user with [a caseworker with an active profile in CCD]
@@ -270,11 +270,9 @@ Feature: F-1017: Validate Event to Update TTL
 
        Then a positive response is received
         And the response has all other details as expected
-        And the response [contains the TTL.SystemTTL for the case, that has been set to 20 days from today]
-        And the response [contains the TTL.OverrideTTL from the previouse data]
-        And the response [does not contain the TTL.Suspended as removed by callback (null -> missing)]
+        And the response [does not contain the TTL as citizen user has no access]
 
-    @S-1017.22 #CCD-3535
+    @S-1017.22 @Smoke #CCD-3535
     Scenario: Trigger a mid event callback that changes TTL.Suspended (No -> NO). Mid Event is invoked on v1_external#/citizen/case-details-endpoint/validateCaseDetailsUsingPOST_1
       Given a user with [an active profile in CCD]
         And a user with [a caseworker with an active profile in CCD]
@@ -293,9 +291,7 @@ Feature: F-1017: Validate Event to Update TTL
 
        Then a positive response is received
         And the response has all other details as expected
-        And the response [contains the TTL.SystemTTL for the case, that has been set to 20 days from today]
-        And the response [does not contain the TTL.OverrideTTL as removed by callback (null -> missing)]
-        And the response [contains the adjusted TTL.Suspended from the callback (No -> NO)]
+        And the response [does not contain the TTL as citizen user has no access]
 
     @S-1017.23 #CCD-3535
     Scenario: Trigger a mid event callback that changes TTL.Suspended (Yes -> YES). Mid Event is invoked on v1_external#/citizen/case-details-endpoint/validateCaseDetailsUsingPOST_1
@@ -316,9 +312,7 @@ Feature: F-1017: Validate Event to Update TTL
 
        Then a positive response is received
         And the response has all other details as expected
-        And the response [contains the TTL.SystemTTL for the case, that has been set to 20 days from today]
-        And the response [does not contain the TTL.OverrideTTL as removed by callback (null -> missing)]
-        And the response [contains the adjusted TTL.Suspended from the callback (Yes -> YES)]
+        And the response [does not contain the TTL as citizen user has no access]
 
 
     @S-1017.25 #CCD-3562
@@ -335,7 +329,7 @@ Feature: F-1017: Validate Event to Update TTL
 
        Then a positive response is received
         And the response has all other details as expected
-        And the response [contains the TTL.SystemTTL for the case, that has been set to 20 days from today]
+        And the response [does not contain the TTL as citizen user has no access]
 
     @S-1017.26 #CCD-3562
     Scenario: Trigger a mid event callback that changes TTL set to null. Mid Event is invoked on v1_external#/citizen/case-details-endpoint/validateCaseDetailsUsingPOST_1

src/aat/resources/features/F-1017 - Validate Event to Update TTL/S-1017.21.td.json

@@ -18,9 +18,7 @@
     "has a TTLIncrement of 20 days configured",
     "is configured to trigger a mid event callback that changes the TTL.Suspended value (null -> missing)",
 
-    "contains the TTL.SystemTTL for the case, that has been set to 20 days from today",
-    "contains the TTL.OverrideTTL from the previouse data",
-    "does not contain the TTL.Suspended as removed by callback (null -> missing)"
+    "does not contain the TTL as citizen user has no access"
   ],
 
   "users": {
@@ -62,10 +60,6 @@
   "expectedResponse": {
     "body": {
       "data": {
-        "TTL": {
-          "SystemTTL": "${[scenarioContext][customValues][dateTwentyDaysFromToday]}",
-          "OverrideTTL": "${[scenarioContext][customValues][dateGreaterThanTTLGuardDate]}"
-        },
         "TextField" : "[[ANYTHING_PRESENT]]"
       }
     }

src/aat/resources/features/F-1017 - Validate Event to Update TTL/S-1017.22.td.json

@@ -19,9 +19,7 @@
     "is configured to trigger a mid event callback that changes the TTL.OverrideTTL value (null -> missing)",
     "is configured to trigger a mid event callback that changes the TTL.Suspended value (No -> NO)",
 
-    "contains the TTL.SystemTTL for the case, that has been set to 20 days from today",
-    "does not contain the TTL.OverrideTTL as removed by callback (null -> missing)",
-    "contains the adjusted TTL.Suspended from the callback (No -> NO)"
+    "does not contain the TTL as citizen user has no access"
   ],
 
   "users": {
@@ -63,10 +61,6 @@
   "expectedResponse": {
     "body": {
       "data": {
-        "TTL": {
-          "SystemTTL": "${[scenarioContext][customValues][dateTwentyDaysFromToday]}",
-          "Suspended": "NO"
-        },
         "TextField" : "[[ANYTHING_PRESENT]]"
       }
     }

src/aat/resources/features/F-1017 - Validate Event to Update TTL/S-1017.23.td.json

@@ -19,9 +19,7 @@
     "is configured to trigger a mid event callback that changes the TTL.OverrideTTL value (null -> missing)",
     "is configured to trigger a mid event callback that changes the TTL.Suspended value (Yes -> YES)",
 
-    "contains the TTL.SystemTTL for the case, that has been set to 20 days from today",
-    "does not contain the TTL.OverrideTTL as removed by callback (null -> missing)",
-    "contains the adjusted TTL.Suspended from the callback (Yes -> YES)"
+    "does not contain the TTL as citizen user has no access"
   ],
 
   "users": {
@@ -63,10 +61,6 @@
   "expectedResponse": {
     "body": {
       "data": {
-        "TTL": {
-          "SystemTTL": "${[scenarioContext][customValues][dateTwentyDaysFromToday]}",
-          "Suspended": "YES"
-        },
         "TextField" : "[[ANYTHING_PRESENT]]"
       }
     }

src/aat/resources/features/F-1017 - Validate Event to Update TTL/S-1017.25.td.json

@@ -16,7 +16,7 @@
     "has a TTLIncrement of 20 days configured",
     "is configured to trigger a mid event callback that responds with TTL missing",
 
-    "contains the TTL.SystemTTL for the case, that has been set to 20 days from today"
+    "does not contain the TTL as citizen user has no access"
   ],
 
   "users": {
@@ -52,11 +52,6 @@
   "expectedResponse": {
     "body": {
       "data": {
-        "TTL" : {
-          "SystemTTL" : "${[scenarioContext][customValues][dateTwentyDaysFromToday]}",
-          "OverrideTTL" : null,
-          "Suspended" : "No"
-        },
         "TextField" : "[[ANYTHING_PRESENT]]"
       }
     }

src/main/java/uk/gov/hmcts/ccd/domain/service/validate/AuthorisedValidateCaseFieldsOperation.java

@@ -63,8 +63,8 @@ public Map<String, JsonNode> validateCaseDetails(OperationContext operationConte
         content.setData(JacksonUtils.convertValue(data));
 
         String caseReference = content.getCaseReference();
-        Set<AccessProfile> accessProfiles = StringUtils.isNotEmpty(caseReference)?
-            caseAccessService.getAccessProfilesByCaseReference(caseReference) :
+        Set<AccessProfile> accessProfiles = StringUtils.isNotEmpty(caseReference)
+            ? caseAccessService.getAccessProfilesByCaseReference(caseReference) :
             caseAccessService.getCaseCreationRoles(caseTypeId);
 
         verifyReadAccess(caseTypeId, content, accessProfiles);