WonderSwan emulation looks for the boot ROM in the current directory #160
Comments
|
At the time load is called, the location attribute hasn't been set yet (it's set 'after' calling load, which makes sense, you can't set an attribute on a node that hasn't been created yet!), meaning that loading files from within the load() function will not use the correct path. This is not a problem with the simple UI as each system has it's own interface which specifies a specific load folder: It's only an issue with the generic method used in the higan-style UI. A potential workaround would be to load firmware at the power() stage, which is what I did with PolyBlast, but I'm not sure that's the best solution. EDIT: This could be the same issue as #161, because the emulation core would be looking for eeprom.save in the root folder (for the same reason), but saving it in the system directory. |
The WonderSwan system(s) include a BIOS ROM and EEPROM data. According to the higan model, this data should be stored in the folder representing a given system. Previously, higan would try to load those files along with everything else in the system folder, however at the time System::load() is called we haven't associated a filesystem path with the system - that's part of the whole loading process. Instead, we load that system data at power-on, after the loading process has sorted out all the filesystem paths we'd need. Hat tip to @LukeUsher for the suggestion. Fixes higan-emu#160, higan-emu#161.
The WonderSwan system(s) include a BIOS ROM and EEPROM data. According to the higan model, this data should be stored in the folder representing a given system. Previously, higan would try to load those files along with everything else in the system folder, however at the time System::load() is called we haven't associated a filesystem path with the system - that's part of the whole loading process. Instead, we load that system data at power-on, after the loading process has sorted out all the filesystem paths we'd need. This matches what the GBA and ColecoVision cores do. Hat tip to @LukeUsher for the suggestion. Fixes higan-emu#160, higan-emu#161.
The WonderSwan system(s) include a BIOS ROM and EEPROM data. According to the higan model, this data should be stored in the folder representing a given system. Previously, higan would try to load those files along with everything else in the system folder, however at the time System::load() is called we haven't associated a filesystem path with the system - that's part of the whole loading process. Instead, we load that system data at power-on, after the loading process has sorted out all the filesystem paths we'd need. This matches what the GBA and ColecoVision cores do. Hat tip to @LukeUsher for the suggestion. Fixes #160, #161.
Steps to reproduce:
Templates/WonderSwan/boot.romexistsExpected results:
Actual results:
boot.romWould you like to browse for this file now?"Systems/WonderSwanboot.romintoSystems/WonderSwanit still complains about it being missingThe text was updated successfully, but these errors were encountered: