-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CI script to build fat x86_64/ARM binaries for macOS #149
Comments
When the Apple M1 chip was first released, somebody on the official discord bought one and compiled higan (and bsnes), and it just worked first time, no porting needed. A thing we could do is to make sure macOS binaries (nightlies and releases) include both x86_64 and ARM support. I'm not sure what's involved in that (I assume step 1 is for GitHub to update their XCode version, I don't know if they've already done that), but if it's not too complex I would accept a PR for that. |
There is some assembly in libco, but it doesn't matter since libco is already ported to many architectures including AArch64. The WIP n64 and psx JITs are both hardcoded using x86 assembly. Those cores need to be excluded from the build until the JIT is ported. (I have done some partial work on this, but haven't pushed it anywhere.) Otherwise Higan compiles perfectly fine on M1. You do need to specify |
Thanks ... I've modified the GNUMakefile (inside byuu) to set local to false. It compiles several files but then errors:
Here is the full log: |
Ah, sorry; I mean to say that the n64 and ps1 cores need to be manually removed. Set the cores variable to remove the ps1 and n64 cores. Just as a note, you do not need to edit the Makefile; you can specify these things as arguments to make, like:
(Good low hanging fruit would be automatically not including ps1 and n64 on platforms where the JIT isn't ported yet.) |
Oh, I'm really sorry... I missed the part where you mentioned excluding the PSX and N64 cores. I've excluded them and it compiles fine. I'll go ahead and close this issue. Thanks so much for the help! |
Sorry - I've re-opened this issue. I see that you changed the title and it would be great to have ARM binaries (ie. Apple M1) to be built automatically. Thanks! |
Are there any efforts to port this to the Apple M1 chip?
I'm not sure if there is x86 assembly (I'm guessing yes?) but I would be great to have a native version for better optimizations, etc.
The text was updated successfully, but these errors were encountered: