-
Notifications
You must be signed in to change notification settings - Fork 127
Client.setNetwork()
does not propagate address book
#2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
2 tasks
steven-sheehy
added a commit
to hiero-ledger/hiero-mirror-node
that referenced
this issue
Apr 29, 2025
Fix acceptance test validation of partial node outage: * Change validation from balance query to topic submit message since query can sometimes succeed for bad endpoints * Workaround partial node outage by removing all endpoints for that node account until sdk [#2317](hiero-ledger/hiero-sdk-java#2317) is fixed Signed-off-by: Steven Sheehy <[email protected]>
steven-sheehy
added a commit
to hiero-ledger/hiero-mirror-node
that referenced
this issue
Apr 29, 2025
Fix acceptance test validation of partial node outage: * Change validation from balance query to topic submit message since query can sometimes succeed for bad endpoints * Workaround partial node outage by removing all endpoints for that node account until sdk [#2317](hiero-ledger/hiero-sdk-java#2317) is fixed Signed-off-by: Steven Sheehy <[email protected]>
Merged
2 tasks
steven-sheehy
added a commit
to hiero-ledger/hiero-mirror-node
that referenced
this issue
Apr 29, 2025
* Change validation from balance query to topic submit message since query can sometimes succeed for bad endpoints * Workaround partial node outage by removing all endpoints for that node account until sdk [#2317](hiero-ledger/hiero-sdk-java#2317) is fixed Signed-off-by: Steven Sheehy <[email protected]>
2 tasks
Fixed in #2322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Similar to #1995, the address book support is still not fully propagated in some scenarios. When adjusting the network, the certificate info inside the
NodeAddressBook
parameter is not passed through toNode.setAddressBookEntry()
so TLS does not work unless we also specifyClient.setVerifyCertificates(false)
, which is less secure. Consider the below:So essentially the problem is you start with a valid address book and
N
nodes, then callsetNetwork()
with some subset ofN
and later add back any of those nodes, the nodes added back do not retain the address book information despite it being present in theNetwork
class. This scenario may seem unconventional but mirror node does this at the start of its acceptance tests to validate each specific endpoints before test execution.The fix is to follow the invariant then whenever a
Node
is created to lookup and set its corresponding address book entry. ProbablyNetwork.createNodeFromNetworkEntry()
just needs to callnode.setAddressBookEntry()
ifaddressBook
is present.The text was updated successfully, but these errors were encountered: