Skip to content

Commit ed760b8

Browse files
committed
HHH-19477 Test aggressive release mode for HQL queries
1 parent e09d58d commit ed760b8

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/jdbc/internal/AggressiveReleaseTest.java

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ protected void cleanupTest() throws Exception {
118118

119119
@Test
120120
public void testBasicRelease() {
121-
connectionProvider.clear();
122121
ResourceRegistry registry = sessionFactoryScope().fromSession(
123122
session -> {
123+
connectionProvider.clear();
124124
JdbcCoordinatorImpl jdbcCoord = (JdbcCoordinatorImpl) session.getJdbcCoordinator();
125125
ResourceRegistry resourceRegistry = jdbcCoord.getLogicalConnection().getResourceRegistry();
126126
try {
@@ -154,9 +154,9 @@ public void testBasicRelease() {
154154

155155
@Test
156156
public void testReleaseCircumventedByHeldResources() {
157-
connectionProvider.clear();
158157
ResourceRegistry registry = sessionFactoryScope().fromSession(
159158
session -> {
159+
connectionProvider.clear();
160160
JdbcCoordinatorImpl jdbcCoord = (JdbcCoordinatorImpl) session.getJdbcCoordinator();
161161
ResourceRegistry resourceRegistry = jdbcCoord.getLogicalConnection().getResourceRegistry();
162162

@@ -217,10 +217,9 @@ public void testReleaseCircumventedByHeldResources() {
217217

218218
@Test
219219
public void testReleaseCircumventedManually() {
220-
connectionProvider.clear();
221-
connectionProvider.clear();
222220
ResourceRegistry registry = sessionFactoryScope().fromSession(
223221
session -> {
222+
connectionProvider.clear();
224223
JdbcCoordinatorImpl jdbcCoord = (JdbcCoordinatorImpl) session.getJdbcCoordinator();
225224
ResourceRegistry resourceRegistry = jdbcCoord.getLogicalConnection().getResourceRegistry();
226225

@@ -271,4 +270,19 @@ public void testReleaseCircumventedManually() {
271270
assertEquals( 0, connectionProvider.getAcquiredConnections().size() );
272271
assertEquals( 2, connectionProvider.getReleasedConnections().size() );
273272
}
273+
274+
@Test
275+
public void testHql() {
276+
sessionFactoryScope().inTransaction( session -> {
277+
connectionProvider.clear();
278+
JdbcCoordinatorImpl jdbcCoord = (JdbcCoordinatorImpl) session.getJdbcCoordinator();
279+
ResourceRegistry resourceRegistry = jdbcCoord.getLogicalConnection().getResourceRegistry();
280+
281+
session.createSelectionQuery( "select 1" ).uniqueResult();
282+
283+
assertFalse( resourceRegistry.hasRegisteredResources() );
284+
assertEquals( 0, connectionProvider.getAcquiredConnections().size() );
285+
assertEquals( 1, connectionProvider.getReleasedConnections().size() );
286+
} );
287+
}
274288
}

0 commit comments

Comments
 (0)