HHH-19480 add missing foreign key constraint to unidirectional @onetomany with referencedColumnName

Author: gavinking

hibernate-core/src/main/java/org/hibernate/mapping/Collection.java

@@ -548,9 +548,16 @@ && isSame( element, other.element )
 
 	private void createForeignKeys() throws MappingException {
 		// if ( !isInverse() ) { // for inverse collections, let the "other end" handle it
+		final String entityName = getOwner().getEntityName();
 		if ( referencedPropertyName == null ) {
 			getElement().createForeignKey();
-			key.createForeignKeyOfEntity( getOwner().getEntityName() );
+			key.createForeignKeyOfEntity( entityName );
+		}
+		else {
+			final Property property = owner.getProperty( referencedPropertyName );
+			assert property != null;
+			key.createForeignKeyOfEntity( entityName,
+					property.getValue().getConstraintColumns() );
 		}
 		// }
 	}

hibernate-core/src/main/java/org/hibernate/mapping/KeyValue.java

@@ -8,6 +8,8 @@
 import org.hibernate.dialect.Dialect;
 import org.hibernate.generator.Generator;
 
+import java.util.List;
+
 /**
  * A mapping model {@link Value} which may be treated as an identifying key of a
  * relational database table. A {@code KeyValue} might represent the primary key
@@ -18,6 +20,8 @@
  */
 public interface KeyValue extends Value {
 
+	ForeignKey createForeignKeyOfEntity(String entityName, List<Column> referencedColumns);
+
 	ForeignKey createForeignKeyOfEntity(String entityName);
 
 	boolean isCascadeDeleteEnabled();

hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java

@@ -351,6 +351,24 @@ public ForeignKey createForeignKeyOfEntity(String entityName) {
 		return null;
 	}
 
+	@Override
+	public ForeignKey createForeignKeyOfEntity(String entityName, List<Column> referencedColumns) {
+		if ( isConstrained() ) {
+			final ForeignKey foreignKey = table.createForeignKey(
+					getForeignKeyName(),
+					getConstraintColumns(),
+					entityName,
+					getForeignKeyDefinition(),
+					getForeignKeyOptions(),
+					referencedColumns
+			);
+			foreignKey.setOnDeleteAction( onDeleteAction );
+			return foreignKey;
+		}
+
+		return null;
+	}
+
 	@Override
 	public void createUniqueKey(MetadataBuildingContext context) {
 		if ( hasFormula() ) {