Skip to content

Commit 42b5fa6

Browse files
nathan.xubeikov
authored andcommitted
remove unnecessary nullness checking in AbstractSqlAstTranslator#visitInsertStatementOnly()
1 parent d53fe49 commit 42b5fa6

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,20 +1269,15 @@ protected void visitInsertStatementOnly(InsertSelectStatement statement) {
12691269
boolean firstPass = true;
12701270

12711271
final List<ColumnReference> targetColumnReferences = statement.getTargetColumns();
1272-
if ( targetColumnReferences == null ) {
1273-
renderImplicitTargetColumnSpec();
1274-
}
1275-
else {
1276-
for (ColumnReference targetColumnReference : targetColumnReferences) {
1277-
if (firstPass) {
1278-
firstPass = false;
1279-
}
1280-
else {
1281-
appendSql( COMMA_SEPARATOR_CHAR );
1282-
}
1283-
1284-
appendSql( targetColumnReference.getColumnExpression() );
1272+
for (ColumnReference targetColumnReference : targetColumnReferences) {
1273+
if (firstPass) {
1274+
firstPass = false;
12851275
}
1276+
else {
1277+
appendSql( COMMA_SEPARATOR_CHAR );
1278+
}
1279+
1280+
appendSql( targetColumnReference.getColumnExpression() );
12861281
}
12871282

12881283
appendSql( ") " );
@@ -1637,9 +1632,6 @@ protected void renderMergeUpdateClause(List<Assignment> assignments, Predicate w
16371632
renderSetClause( assignments );
16381633
}
16391634

1640-
private void renderImplicitTargetColumnSpec() {
1641-
}
1642-
16431635
protected void visitValuesList(List<Values> valuesList) {
16441636
visitValuesListStandard( valuesList );
16451637
}

0 commit comments

Comments
 (0)