Skip to content

Commit 845b74a

Browse files
authored
Fix typos and other inconsistencies in comments, tests and CHANGELOG (#2070)
As found by a Claude Code review pass of docs/comments/tests.
1 parent 843f76f commit 845b74a

File tree

14 files changed

+25
-26
lines changed

14 files changed

+25
-26
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ shell_variant = bash
2929
switch_case_indent = true
3030

3131
# The setup-ruby GitHub Action creates this directory when caching is enabled, and if
32-
# its not ignored will cause false positives when running shfmt in the CI lint job.
32+
# it's not ignored will cause false positives when running shfmt in the CI lint job.
3333
[vendor/bundle/**]
3434
ignore = true
3535

CHANGELOG.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
## [v318] - 2025-11-12
125125

126126
- Improved the error message shown when a `.python-version` file uses an unsupported file encoding. ([#1958](https://github.com/heroku/heroku-buildpack-python/pull/1958))
127-
- Improved the error message shown when a `.python-version` or `runtime.txt` file contain an invalid Python version. ([#1958](https://github.com/heroku/heroku-buildpack-python/pull/1958))
127+
- Improved the error message shown when a `.python-version` or `runtime.txt` file contains an invalid Python version. ([#1958](https://github.com/heroku/heroku-buildpack-python/pull/1958))
128128
- Added support for commented lines in `runtime.txt`, for parity with `.python-version`. ([#1958](https://github.com/heroku/heroku-buildpack-python/pull/1958))
129129

130130
## [v317] - 2025-11-03
@@ -259,7 +259,7 @@
259259
## [v292] - 2025-07-23
260260

261261
- Updated Pipenv from 2024.0.1 to 2025.0.4. ([#1840](https://github.com/heroku/heroku-buildpack-python/pull/1840))
262-
- Fixed the way Pipenv is installed, so that it and its dependencies are installed into a separate virtual environment rather than same environment as the app. If your app inadvertently depended on Pipenv's internal dependencies, you will need to add those dependencies explicitly to your `Pipfile`. ([#1840](https://github.com/heroku/heroku-buildpack-python/pull/1840))
262+
- Fixed the way Pipenv is installed, so that it and its dependencies are installed into a separate virtual environment rather than the same environment as the app. If your app inadvertently depended on Pipenv's internal dependencies, you will need to add those dependencies explicitly to your `Pipfile`. ([#1840](https://github.com/heroku/heroku-buildpack-python/pull/1840))
263263
- Stopped installing pip when Pipenv is the chosen package manager. ([#1840](https://github.com/heroku/heroku-buildpack-python/pull/1840))
264264
- The build cache is now cleared when using Pipenv if the contents of `Pipfile.lock` has changed since the last build. This is required to work around Pipenv not uninstalling packages when they are removed from the lockfile. ([#1840](https://github.com/heroku/heroku-buildpack-python/pull/1840))
265265
- The build now errors when using Pipenv without its lockfile (`Pipfile.lock`). This replaces the warning displayed since November 2024. ([#1833](https://github.com/heroku/heroku-buildpack-python/pull/1833))
@@ -555,7 +555,7 @@
555555

556556
## [v243] - 2024-02-07
557557

558-
- Added support for Python 3.11.8 and 3.12.2. ([#1538](https://github.com/heroku/heroku-buildpack-python/pull/1538)).
558+
- Added support for Python 3.11.8 and 3.12.2. ([#1538](https://github.com/heroku/heroku-buildpack-python/pull/1538))
559559
- Changed the default Python version for new apps from 3.12.1 to 3.12.2. ([#1538](https://github.com/heroku/heroku-buildpack-python/pull/1538))
560560

561561
## [v242] - 2024-01-11
@@ -566,8 +566,8 @@
566566

567567
## [v241] - 2023-12-08
568568

569-
- Changed the default Python version for new apps from Python 3.11 to Python 3.12. ([#1516](https://github.com/heroku/heroku-buildpack-python/pull/1516)).
570-
- Added support for Python 3.11.7 and 3.12.1. ([#1517](https://github.com/heroku/heroku-buildpack-python/pull/1517) and [#1518](https://github.com/heroku/heroku-buildpack-python/pull/1518)).
569+
- Changed the default Python version for new apps from Python 3.11 to Python 3.12. ([#1516](https://github.com/heroku/heroku-buildpack-python/pull/1516))
570+
- Added support for Python 3.11.7 and 3.12.1. ([#1517](https://github.com/heroku/heroku-buildpack-python/pull/1517) and [#1518](https://github.com/heroku/heroku-buildpack-python/pull/1518))
571571
- Added a deprecation warning for Python 3.8. ([#1515](https://github.com/heroku/heroku-buildpack-python/pull/1515))
572572

573573
## [v240] - 2023-11-30
@@ -1443,7 +1443,7 @@ Updated pip and Setuptools.
14431443

14441444
Added warnings for lack of Procfile.
14451445

1446-
## v72 - 2015-12-07
1446+
## v73 - 2015-12-07
14471447

14481448
Updated default Python to 2.7.11.
14491449

bin/compile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# See: https://devcenter.heroku.com/articles/buildpack-api
44

55
# We use `errtrace` and `inherit_errexit` to ensure the ERR trap and exit on error behaviour
6-
# propagates to buildpack functions run in subshells, such when using command substitutions.
6+
# propagates to buildpack functions run in subshells, such as when using command substitutions.
77
set -eu -o pipefail -o errtrace
88
shopt -s inherit_errexit
99

@@ -56,7 +56,6 @@ export BUILD_DIR CACHE_DIR ENV_DIR
5656
unset PYTHONHOME PYTHONPATH
5757

5858
# Import the warnings script, which contains the `pip install` user warning mechanisms
59-
# (mentioned and explained above)
6059
source "${BUILDPACK_DIR}/bin/warnings"
6160

6261
# Make the directory in which we will create symlinks from the temporary build directory
@@ -76,7 +75,7 @@ python_home='/app/.heroku/python'
7675
# using `/app` paths which will still work at run-time after relocation. Amongst other things, this
7776
# ensures that the shebang lines in the entrypoint scripts of installed packages are correct.
7877
export PATH="/app/.heroku/python/bin:${PATH}"
79-
# Tell Python to not buffer it's stdin/stdout.
78+
# Tell Python to not buffer its stdin/stdout.
8079
export PYTHONUNBUFFERED=1
8180
# Ensure Python uses a Unicode locale, to prevent the issues described in:
8281
# https://github.com/docker-library/python/pull/570
@@ -266,7 +265,7 @@ EOT
266265
#
267266
# In addition to ensuring dependencies work for subsequent buildpacks and at runtime, they must also
268267
# work for cached rebuilds. Most package managers will reinstall editable dependencies regardless on
269-
# next install, which means we can avoid having to rewrite paths on cache restore from the old build
268+
# the next install, which means we can avoid having to rewrite paths on cache restore from the old build
270269
# directory to the new location (`/tmp/build_<different-hash>`). However, Pipenv has a bug when using
271270
# PEP660 style editable VCS dependencies where it won't reinstall if it's missing (or in our case, the
272271
# path has changed), which means we must make sure that VCS src paths stored in the cache do use the

builds/build_python_runtime.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ CONFIGURE_OPTS=(
104104
# and not the static library (such as `pycall.rb` or `PyO3`).
105105
# - More consistent with the official Python Docker images and other distributions.
106106
#
107-
# Shared builds are slower unless `no-semantic-interposition`and LTO is used,
107+
# Shared builds are slower unless `no-semantic-interposition` and LTO are used,
108108
# however, as of Python 3.10 `no-semantic-interposition` is enabled by default:
109109
# https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup
110110
# https://github.com/python/cpython/issues/83161

builds/test_python_runtime.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ if "${INSTALL_DIR}/bin/python3" -c "import $(
8888
IFS=,
8989
echo "${optional_stdlib_modules[*]}"
9090
)"; then
91-
echo "Successful imported: ${optional_stdlib_modules[*]}"
91+
echo "Successfully imported: ${optional_stdlib_modules[*]}"
9292
else
9393
abort "The above optional stdlib module failed to import! Check the compile logs to see if it was skipped due to missing libraries/headers."
9494
fi

lib/cache.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ function cache::save() {
181181
# but not Heroku CI or build-in-app-dir. Ideally we would be able to use `--reflink=auto` here
182182
# (which would avoid the need for a conditional and also mean accidental edits by users in later
183183
# buildpacks to one location doesn't affect the other), however, with the current filesystems
184-
# used in production benchmarking showed `--reflinks=auto` was much slower than hardlinks.
184+
# used in production benchmarking showed `--reflink=auto` was much slower than hardlinks.
185185
if [[ "${build_dir_filesystem}" == "${cache_dir_filesystem}" ]]; then
186186
local additional_copy_args=(--link)
187187
else

lib/hooks.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# however, it helps Shellcheck realise the options under which these functions will run.
55
set -euo pipefail
66

7-
# Used to run the `bin/pre_compile` and `bin/post_compile`s scripts if found in the app source,
7+
# Used to run the `bin/pre_compile` and `bin/post_compile` scripts if found in the app source,
88
# allowing for build customisation.
99
function hooks::run_hook() {
1010
local hook_name="${1}"

lib/python_version.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ function python_version::read_requested_python_version() {
128128
fi
129129
fi
130130

131-
# Protect against unsupported (eg PyPy) or invalid versions being found in the cache metadata.
131+
# Protect against unsupported (e.g. PyPy) or invalid versions being found in the cache metadata.
132132
if [[ "${cached_python_full_version}" =~ ^${PYTHON_FULL_VERSION_REGEX}$ ]]; then
133133
local cached_python_major_version="${cached_python_full_version%.*}"
134134
version="${cached_python_major_version}"

lib/utils.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function utils::bundled_pip_module_path() {
2727
# We have to use a glob since the bundled wheel filename contains the pip version, which differs
2828
# between Python versions. We use compgen to avoid having to set nullglob, since there may be no
2929
# matches in the case of a broken Python install. We also have to handle the case where there are
30-
# multiple matching pip wheels, since in some versions of Python (eg 3.9.0) multiple versions of
30+
# multiple matching pip wheels, since in some versions of Python (e.g. 3.9.0) multiple versions of
3131
# pip were accidentally bundled upstream (we use tail since we want the newest pip version).
3232
if bundled_pip_wheel="$(compgen -G "${bundled_wheels_dir}/pip-*.whl" | tail --lines=1)"; then
3333
# The pip module exists inside the pip wheel (which is a zip file), however, Python can load

lib/uv.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function uv::install_uv() {
2525
mkdir -p "${uv_dir}"
2626

2727
local gnu_arch
28-
# eg: `x86_64` or `aarch64`.
28+
# e.g.: `x86_64` or `aarch64`.
2929
gnu_arch=$(arch)
3030
local uv_url="https://releases.astral.sh/github/uv/releases/download/${UV_VERSION}/uv-${gnu_arch}-unknown-linux-gnu.tar.gz"
3131

0 commit comments

Comments
 (0)