Skip to content

Dev setup instructions result in errors #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viraptor opened this issue Apr 3, 2025 · 2 comments
Closed

Dev setup instructions result in errors #3268

viraptor opened this issue Apr 3, 2025 · 2 comments

Comments

@viraptor
Copy link

viraptor commented Apr 3, 2025

Installing defined node version and following the two build commands from readme results in errors:

$ yarn build
src/commands/ci/config/get.ts:3:30 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

3 import * as shellescape from 'shell-escape'
                               ~~~~~~~~~~~~~~

src/commands/ci/config/index.ts:5:30 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

5 import * as shellescape from 'shell-escape'
                               ~~~~~~~~~~~~~~

src/commands/domains/add.ts:7:30 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

7 import * as shellescape from 'shell-escape'
                               ~~~~~~~~~~~~~~

src/commands/releases/info.ts:5:30 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

5 import * as shellescape from 'shell-escape'
                               ~~~~~~~~~~~~~~

src/lib/domains/domains.ts:2:30 - error TS2305: Module '"psl"' has no exported member 'ParseError'.

2 import {parse, ParsedDomain, ParseError} from 'psl'
                               ~~~~~~~~~~

src/lib/domains/domains.ts:26:28 - error TS2339: Property 'error' does not exist on type 'ParsedDomain | ErrorResult<number | unique symbol | "length" | "at" | "toString" | "charAt" | "charCodeAt" | "concat" | "indexOf" | "lastIndexOf" | "localeCompare" | "match" | ... 37 more ... | "matchAll">'.
  Property 'error' does not exist on type 'ParsedDomain'.

26     throw new Error(parsed.error.message)
                              ~~~~~

src/lib/domains/domains.ts:29:17 - error TS2339: Property 'subdomain' does not exist on type 'never'.

29   return parsed.subdomain === null ? 'ALIAS/ANAME' : 'CNAME'
                   ~~~~~~~~~

src/lib/notify.ts:12:7 - error TS2345: Argument of type '{ title: string; subtitle: string; message: string; contentImage: string; sound: boolean; }' is not assignable to parameter of type 'Notification'.
  Object literal may only specify known properties, and 'subtitle' does not exist in type 'Notification'.

12       subtitle,
         ~~~~~~~~

src/lib/pg/backups.ts:42:5 - error TS2322: Type 'string | null' is not assignable to type 'string'.
  Type 'null' is not assignable to type 'string'.

42     return bytes(size, opts)
       ~~~~~~~~~~~~~~~~~~~~~~~~


Found 9 errors in 7 files.

Errors  Files
     1  src/commands/ci/config/get.ts:3
     1  src/commands/ci/config/index.ts:5
     1  src/commands/domains/add.ts:7
     1  src/commands/releases/info.ts:5
     3  src/lib/domains/domains.ts:2
     1  src/lib/notify.ts:12
     1  src/lib/pg/backups.ts:42

Same thing for master and the latest tag.

Are there extra version requirements on any tools / extra steps necessary?

@sbosio
Copy link
Contributor

sbosio commented Apr 15, 2025

Hi @viraptor, please confirm the following information so we can properly investigate:

  • Platform (linux, darwin, windows) and arch (x64, arm).
  • Node version (node -v)

If you're working on a fork of this repository I recommend ensuring you have the latest main branch checked out, then running yarn and yarn build. Check if the output from the first yarn command (dependencies installation) succeeds without errors.

@viraptor
Copy link
Author

I'm running on darwin, arm. Node version as defined in the repo (v20.18.2 when trying cli v10.4.1).
The latest tag and main don't seem to have this problem anymore, so 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants