Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show migration advice for apps using bin/{pre,post}_compile scripts #288

Open
edmorley opened this issue Nov 5, 2024 · 0 comments
Open
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack

Comments

@edmorley
Copy link
Member

edmorley commented Nov 5, 2024

Apps using the proprietary bin/{pre,post}_compile scripts should migrate to using the upstream CNB inline buildpack feature:
https://buildpacks.io/docs/for-app-developers/how-to/build-inputs/use-inline-buildpacks/

We should:

  1. Make the build error if an app has one of those scripts, instructing them to remove the script and migrate to the inline buildpack. This error should give an example of what to add to project.toml, and link to the upstream docs.
  2. Make some improvements to the upstream docs (eg: show the shorter syntax style, and also give an example using the io.buildpacks.post.group feature)

See:

GUS-W-17140857.

@edmorley edmorley added the classic buildpack parity Features required for parity with the classic Heroku Python buildpack label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack
Projects
None yet
Development

No branches or pull requests

1 participant