Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to continue buildpack NLTK support #146

Open
edmorley opened this issue Nov 23, 2023 · 0 comments
Open

Decide whether to continue buildpack NLTK support #146

edmorley opened this issue Nov 23, 2023 · 0 comments
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack

Comments

@edmorley
Copy link
Member

edmorley commented Nov 23, 2023

The classic Python buildpack supports installing NLTK corpora via an nltk.txt file:
https://devcenter.heroku.com/articles/python-nltk
https://github.com/heroku/heroku-buildpack-python/blob/main/bin/steps/nltk
https://www.nltk.org/data.html

This is a someone infrequently used feature, and it seems it could be replaced by an inline buildpack that runs a single command.

Though we'd need to check whether NLTK_DATA needs to be set, or if we can rely on the default output location.

If we do decide to drop this feature, we'll want to display migration advice in the CNB. Or if we don't drop the feature, we'll need to implement support for it in the CNB.

GUS-W-17140864.

@edmorley edmorley added the classic buildpack parity Features required for parity with the classic Heroku Python buildpack label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack
Projects
None yet
Development

No branches or pull requests

1 participant