Move close(pipe_[]) from Teardown() to Deinitialize

It removes possibility close and write will appear simultaneously
in different threads

Relates-To: NLAM-166

Signed-off-by: Alexander Sopov <[email protected]>

Author: asopov-here

olp-cpp-sdk-core/src/http/curl/NetworkCurl.cpp

@@ -558,11 +558,17 @@ void NetworkCurl::Deinitialize() {
     }
 #endif
     thread_.join();
+
+#if (defined OLP_SDK_NETWORK_HAS_PIPE) || (defined OLP_SDK_NETWORK_HAS_PIPE2)
+    close(pipe_[0]);
+    close(pipe_[1]);
+#endif
   } else {
     // We are trying to stop the very thread we are in. This is not recommended,
     // but we try to handle it gracefully. This could happen by calling from one
     // of the static functions (rxFunction or headerFunction) that was passed to
     // the cURL as callbacks.
+    assert(false);
     thread_.detach();
   }
 }
@@ -589,11 +595,6 @@ void NetworkCurl::Teardown() {
     // cURL teardown
     curl_multi_cleanup(curl_);
     curl_ = nullptr;
-
-#if (defined OLP_SDK_NETWORK_HAS_PIPE) || (defined OLP_SDK_NETWORK_HAS_PIPE2)
-    close(pipe_[0]);
-    close(pipe_[1]);
-#endif
   }
 
   // Handle completed messages