Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up into seperate projects? #1

Open
timme04 opened this issue Aug 18, 2016 · 1 comment
Open

Split up into seperate projects? #1

timme04 opened this issue Aug 18, 2016 · 1 comment

Comments

@timme04
Copy link

timme04 commented Aug 18, 2016

Hi,
i like your Dockerfiles very much. ATM I'm just using your dockerized KNXd which works very well on my Synology since several months.

What do you think about splitting up your "subprojects" like owfs, knxd, smarthomeNG and maybe the docker-compose.yml to seperate projects?

This would make (for example) submitting pull requests and seperation of concerns much more clear in my opinion.

I, personally, don't have any use for owfs docker-stuff, but if i clone your repo it's in there atm.

What do you think?
Regards,
Christian

@henfri
Copy link
Owner

henfri commented Oct 24, 2016

Hello,

sorry for the late reply. I don't get the point of seperate docker-commpose.yml because the docker-compose.yml does combine the projects to one suite that uses all of the containers.

But I'll consider it once the number of pull requests increases, if it makes it all more managable.

Greetings,
Hendrik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants