auto trust newly created user files

Author: usering-around

helix-loader/src/trust_db.rs

@@ -142,7 +142,7 @@ fn trust_db_file() -> PathBuf {
 
 pub fn is_workspace_trusted(path: impl AsRef<Path>) -> Result<Option<bool>> {
     let Ok(path) = path.as_ref().canonicalize() else {
-        return Ok(Some(false));
+        return Ok(None);
     };
 
     TRUST_DB.inspect(|db| db.is_workspace_trusted(path))

helix-term/src/events.rs

@@ -2,7 +2,8 @@ use helix_event::{events, register_event};
 use helix_view::document::Mode;
 use helix_view::events::{
     ConfigDidChange, DiagnosticsDidChange, DocumentDidChange, DocumentDidClose, DocumentDidOpen,
-    DocumentFocusLost, LanguageServerExited, LanguageServerInitialized, SelectionDidChange,
+    DocumentFocusLost, FileCreated, LanguageServerExited, LanguageServerInitialized,
+    SelectionDidChange,
 };
 
 use crate::commands;
@@ -27,4 +28,5 @@ pub fn register() {
     register_event::<LanguageServerInitialized>();
     register_event::<LanguageServerExited>();
     register_event::<ConfigDidChange>();
+    register_event::<FileCreated>();
 }

helix-term/src/handlers/trust.rs

@@ -8,6 +8,7 @@ use anyhow::anyhow;
 use helix_stdx::env::set_current_working_dir;
 use helix_view::editor::WorkspaceTrust;
 use helix_view::events::DocumentDidOpen;
+use helix_view::events::FileCreated;
 use helix_view::handlers::Handlers;
 use helix_view::theme::Modifier;
 use helix_view::theme::Style;
@@ -136,10 +137,9 @@ fn choose_parent_dialog(path: impl AsRef<Path>, trust: bool) -> impl Component +
 pub(super) fn register_hooks(_handlers: &Handlers) {
     helix_event::register_hook!(move |event: &mut DocumentDidOpen<'_>| {
         if event.editor.config.load().workspace_trust == WorkspaceTrust::Ask
-            && event
-                .editor
-                .document(event.doc)
-                .is_some_and(|doc| doc.path().is_some() && doc.is_trusted.is_none())
+            && event.editor.document(event.doc).is_some_and(|doc| {
+                doc.path().is_some_and(|p| p.exists()) && doc.is_trusted.is_none()
+            })
         {
             // these unwraps are fine due to the above. TODO: change this to if let chains once rust is bumped to 1.88
             let path = event
@@ -157,4 +157,26 @@ pub(super) fn register_hooks(_handlers: &Handlers) {
 
         Ok(())
     });
+
+    helix_event::register_hook!(move |event: &mut FileCreated| {
+        let path = event.path.clone();
+        crate::job::dispatch_blocking(move |editor, _compositor| {
+            if !matches!(
+                editor.config().workspace_trust,
+                WorkspaceTrust::Ask | WorkspaceTrust::Manual
+            ) {
+                return;
+            }
+            if let Some(doc) = editor.document_by_path(&path) {
+                if doc.is_trusted.is_none() {
+                    if let Err(e) = editor.trust_workspace(path) {
+                        editor.set_error(format!(
+                            "Couldn't trust file: {e}; use :trust-workspace to trust it"
+                        ))
+                    }
+                }
+            }
+        });
+        Ok(())
+    });
 }

helix-view/src/document.rs

@@ -119,6 +119,7 @@ pub struct DocumentSavedEvent {
     pub save_time: SystemTime,
     pub doc_id: DocumentId,
     pub path: PathBuf,
+    pub is_newly_created: bool,
     pub text: Rope,
 }
 
@@ -1051,9 +1052,10 @@ impl Document {
                 ));
             }
 
+            let path_exists = path.exists();
             // Assume it is a hardlink to prevent data loss if the metadata cant be read (e.g. on certain Windows configurations)
             let is_hardlink = helix_stdx::faccess::hardlink_count(&write_path).unwrap_or(2) > 1;
-            let backup = if path.exists() && atomic_save {
+            let backup = if path_exists && atomic_save {
                 let path_ = write_path.clone();
                 // hacks: we use tempfile to handle the complex task of creating
                 // non clobbered temporary path for us we don't want
@@ -1139,6 +1141,7 @@ impl Document {
                 save_time,
                 doc_id,
                 path,
+                is_newly_created: !path_exists,
                 text: text.clone(),
             };
 

helix-view/src/editor.rs

@@ -2043,6 +2043,11 @@ impl Editor {
             let res = doc_save_future.await;
             if let Ok(event) = &res {
                 handler.file_changed(event.path.clone());
+                if event.is_newly_created {
+                    helix_event::dispatch(crate::events::FileCreated {
+                        path: event.path.clone(),
+                    })
+                }
             }
             res
         };

helix-view/src/events.rs

@@ -1,10 +1,15 @@
+use std::path::PathBuf;
+
 use helix_core::{ChangeSet, Rope};
 use helix_event::events;
 use helix_lsp::LanguageServerId;
 
 use crate::{editor::Config, Document, DocumentId, Editor, ViewId};
 
 events! {
+    FileCreated {
+        path: PathBuf
+    }
     DocumentDidOpen<'a> {
         editor: &'a mut Editor,
         doc: DocumentId