Fix svelte-check errors

Signed-off-by: Andrey Sobolev <[email protected]>

Author: haiodo

common/scripts/svelte-check-show.sh

@@ -0,0 +1,19 @@
+#!/bin/sh
+
+roots=$(rush list -p --json | grep "path" | cut -f 2 -d ':' | cut -f 2 -d '"')
+files="svelte-check.log svelte-check-err.log"
+for file in $roots; do
+  for check in $files; do
+    f="$file/.svelte-check/$check"
+    if [ -f $f ]; then
+      if grep -q "error" "$f"; then
+        if ! grep -q "0 errors" "$f"; then
+          if ! grep -q "error.ts" "$f"; then
+            echo "\nErrors in $f\n"
+            cat "$f" | grep -B1 "Error:" | grep -v "^--$" | sed "s/Error:/$(echo '\033[31m')Error:$(echo '\033[0m')/"
+          fi
+        fi
+      fi
+    fi
+  done
+done

packages/platform-rig/bin/do-svelte-check.js

@@ -1,10 +1,47 @@
-const { join, dirname } = require("path")
+const { join, dirname } = require('path')
 const { readFileSync, existsSync, mkdirSync, createWriteStream } = require('fs')
 const { spawn } = require('child_process')
 
+function parseSvelteCheckLog(logContent) {
+  const lines = logContent.split('\n')
+  const errors = []
+  let currentError = null
+
+  let pline = ''
+  for (const line of lines) {
+    if (line.includes('Error:')) {
+      // Start of a new error
+      if (currentError) {
+        errors.push(currentError)
+      }
+      currentError = {
+        file: pline,
+        message: line.split('Error:')[1].trim()
+      }      
+    } else if (line.includes('====================================')) {
+      // End of log, push last error if exists
+      if (currentError) {
+        errors.push(currentError)
+      }
+      break
+    }
+    pline = line
+  }
+
+  // Print errors
+  if (errors.length === 0) {
+    console.log('No errors found')
+  } else {
+    errors.forEach((error) => {
+      console.log(`File: ${error.file}`)
+      console.log(`Message: \x1b[31m ${error.message} \x1b[0m\n`)
+    })
+  }
+}
+
 async function execProcess(cmd, logFile, args, useConsole) {
   let compileRoot = dirname(dirname(process.argv[1]))
-  console.log("Svelte check...\n", process.cwd(), args)
+  console.log('Svelte check...\n')
 
   if (!existsSync(join(process.cwd(), '.svelte-check'))) {
     mkdirSync(join(process.cwd(), '.svelte-check'))
@@ -15,16 +52,15 @@ async function execProcess(cmd, logFile, args, useConsole) {
   const stdoutFilePath = `.svelte-check/${logFile}.log`
   const stderrFilePath = `.svelte-check/${logFile}-err.log`
 
-
   const outPromise = new Promise((resolve) => {
     if (compileOut.stdout != null) {
       let outPipe = createWriteStream(stdoutFilePath)
       compileOut.stdout.pipe(outPipe)
       compileOut.stdout.on('end', function (data) {
         outPipe.close()
-        if( useConsole ) {
-          console.log(readFileSync(stdoutFilePath).toString())
-          console.log(readFileSync(stderrFilePath).toString())
+        if (useConsole) {
+          const data = readFileSync(stdoutFilePath).toString() + readFileSync(stderrFilePath).toString()
+          parseSvelteCheckLog(data)
         }
         resolve()
       })
@@ -47,7 +83,7 @@ async function execProcess(cmd, logFile, args, useConsole) {
   })
 
   let editCode = 0
-  const closePromise = new Promise(resolve => {
+  const closePromise = new Promise((resolve) => {
     compileOut.on('close', (code) => {
       editCode = code
       resolve()
@@ -61,30 +97,26 @@ async function execProcess(cmd, logFile, args, useConsole) {
   await Promise.all([outPromise, errPromise, closePromise])
 
   if (editCode !== 0) {
-    const data = readFileSync(stdoutFilePath)
-    const errData = readFileSync(stderrFilePath)
-    console.error('\n' + data.toString() + '\n' + errData.toString())
+    if( !useConsole) {
+      const data = readFileSync(stdoutFilePath).toString()
+      const errData = readFileSync(stderrFilePath).toString()
+      parseSvelteCheckLog(data)
+      console.error('\n' + errData.toString())
+    }
     process.exit(editCode)
   }
 }
 
 let args = [] // process.argv.slice(2)
 let useConsole = false
-for(const a of process.argv.slice(2)) {
-  if( a === '--console') {
+for (const a of process.argv.slice(2)) {
+  if (a === '--console') {
     useConsole = true
   } else {
     args.push(a)
   }
 }
 let st = performance.now()
-execProcess(
-  'svelte-check',
-  'svelte-check', [
-  '--output', 'human',
-  ...args  
-], useConsole)
-  .then(() => {
-    console.log("Svelte check time: ", Math.round((performance.now() - st) * 100) / 100)
-  })
-
+execProcess('svelte-check', 'svelte-check', ['--output', 'human', ...args], useConsole).then(() => {
+  console.log('Svelte check time: ', Math.round((performance.now() - st) * 100) / 100)
+})

plugins/attachment-resources/src/components/FileBrowser.svelte

@@ -116,7 +116,7 @@
         ]}
         selected={isListDisplayMode ? 'table' : 'card'}
         on:select={(result) => {
-          if (result.detail !== undefined) isListDisplayMode = result.detail === 'table' ?? false
+          if (result.detail !== undefined) isListDisplayMode = result.detail === 'table'
         }}
       />
     </div>

plugins/diffview-resources/src/components/InlineDiffView.svelte

@@ -29,7 +29,7 @@ index 3aa8590..6b64999 100644
 +++ b/${fileName}
 `
 
-  $: diffFiles = parseDiff(prefix + patch ?? '')
+  $: diffFiles = parseDiff(prefix + patch)
 </script>
 
 {#each diffFiles as diffFile}

plugins/gmail-resources/src/components/FullMessage.svelte

@@ -24,14 +24,11 @@
   import attachment, { Attachment } from '@hcengineering/attachment'
   import { AttachmentPresenter } from '@hcengineering/attachment-resources'
   import { getEmbeddedLabel } from '@hcengineering/platform'
-  import core, { Ref } from '@hcengineering/core'
+  import { Ref } from '@hcengineering/core'
 
   export let currentMessage: SharedMessage
   export let newMessage: boolean
 
-  let editor: HTMLDivElement
-  $: if (editor) editor.innerHTML = currentMessage.content
-
   const dispatch = createEventDispatcher()
   const hasError = (currentMessage as unknown as NewMessage)?.status === 'error'
 

plugins/gmail-resources/src/components/Message.svelte

@@ -63,9 +63,8 @@
     {/if}
     {#if isError}
       <div class="error-color top-divider mt-2 pt-2">
-        Error: {errorMessage?.error
-          ? JSON.parse(errorMessage.error)?.data?.error_description
-          : undefined ?? 'unknown error'}
+        Error: {(errorMessage?.error ? JSON.parse(errorMessage.error)?.data?.error_description : undefined) ??
+          'unknown error'}
       </div>
     {/if}
   </div>

plugins/love-resources/src/components/Settings.svelte

@@ -69,7 +69,7 @@
       <div class="flex-row-center flex-gap-4">
         <Label label={love.string.StartWithMutedMic} />
         <Toggle
-          on={!$myPreferences?.micEnabled ?? false}
+          on={!($myPreferences?.micEnabled ?? false)}
           on:change={(e) => {
             saveMicPreference($myPreferences, e.detail)
           }}
@@ -78,7 +78,7 @@
       <div class="flex-row-center flex-gap-4">
         <Label label={love.string.StartWithoutVideo} />
         <Toggle
-          on={!$myPreferences?.camEnabled ?? false}
+          on={!($myPreferences?.camEnabled ?? false)}
           on:change={(e) => {
             saveCamPreference($myPreferences, e.detail)
           }}

plugins/tags-resources/src/components/TagsView.svelte

@@ -92,8 +92,7 @@
     }
   )
   const countSorting = (a: Doc, b: Doc) =>
-    (tagElements?.get(b._id as Ref<TagElement>)?.count ?? 0) -
-      (tagElements?.get(a._id as Ref<TagElement>)?.count ?? 0) ?? 0
+    (tagElements?.get(b._id as Ref<TagElement>)?.count ?? 0) - (tagElements?.get(a._id as Ref<TagElement>)?.count ?? 0)
 
   let visibleCategories: TagCategory[] = []
 </script>

plugins/test-management-resources/src/components/test-case/EditTestCase.svelte

@@ -52,8 +52,6 @@
     }
   }
 
-  let content: HTMLElement
-
   $: if (oldLabel !== object?.name) {
     oldLabel = object?.name
     rawLabel = object?.name
@@ -102,7 +100,6 @@
         bind:this={descriptionBox}
         identifier={object?._id}
         placeholder={testManagement.string.DescriptionPlaceholder}
-        boundary={content}
       />
     </div>
 

plugins/test-management-resources/src/components/test-result/TestResultAside.svelte

@@ -37,8 +37,6 @@
 
   let descriptionBox: AttachmentStyleBoxCollabEditor
 
-  let content: HTMLElement
-
   $: descriptionKey = hierarchy.getAttribute(testManagement.class.TestResult, 'description')
 
   onMount(() => dispatch('open', { ignoreKeys: [] }))
@@ -57,7 +55,6 @@
       bind:this={descriptionBox}
       identifier={object?._id}
       placeholder={testManagement.string.DescriptionPlaceholder}
-      boundary={content}
     />
   </div>
   {#if !withoutActivity}
@@ -67,8 +64,7 @@
         props={{
           object,
           showCommenInput: true,
-          focusIndex: 1000,
-          boundary: content
+          focusIndex: 1000
         }}
       />
     </div>

plugins/test-management-resources/src/components/test-run/EditTestRun.svelte

@@ -51,8 +51,6 @@
     }
   }
 
-  let content: HTMLElement
-
   $: if (oldLabel !== object?.name) {
     oldLabel = object?.name
     rawLabel = object?.name
@@ -98,7 +96,6 @@
         bind:this={descriptionBox}
         identifier={object?._id}
         placeholder={testManagement.string.DescriptionPlaceholder}
-        boundary={content}
       />
     </div>
 

plugins/text-editor-resources/src/components/CollaboratorEditor.svelte

@@ -48,8 +48,6 @@
   export let requestSideSpace: ((width: number) => void) | undefined = undefined
   export let enableInlineComments: boolean = true
 
-  let element: HTMLElement
-
   let collaborativeEditor: CollaborativeTextEditor
 
   export function commands (): TextEditorCommandHandler | undefined {
@@ -68,7 +66,7 @@
   const { idx, focusManager } = registerFocus(focusIndex, {
     focus: () => {
       focus()
-      return element !== null
+      return true
     },
     isFocus: () => isFocused(),
     canBlur: () => false

plugins/tracker-resources/src/components/issues/StatusEditor.svelte

@@ -124,7 +124,7 @@
       id: s._id,
       component: StatusPresenter,
       props: { value: s, size: 'small', space: value.space },
-      isSelected: selectedStatus?._id === s._id ?? false
+      isSelected: selectedStatus?._id === s._id
     }
   })
   $: smallgap = size === 'inline' || size === 'small'

plugins/tracker-resources/src/components/issues/StatusSelector.svelte

@@ -106,7 +106,7 @@
         id: s._id,
         component: StatusPresenter,
         props: { value: s, size: 'small' },
-        isSelected: selectedStatus?._id === s._id ?? false
+        isSelected: selectedStatus?._id === s._id
       }
     }) ?? []
   const handleStatusEditorOpened = (event: MouseEvent) => {

plugins/tracker-resources/src/components/milestones/MilestoneBrowser.svelte

@@ -58,10 +58,6 @@
     asideFloat = false
     asideShown = false
   }
-  let docWidth: number
-  let docSize: boolean = false
-  $: if (docWidth <= 900 && !docSize) docSize = true
-  $: if (docWidth > 900 && docSize) docSize = false
 
   const handleViewModeChanged = (newMode: MilestoneViewMode) => {
     if (newMode === undefined || newMode === mode) {

plugins/view-resources/src/components/filter/FilterSection.svelte

@@ -48,7 +48,7 @@
     }
   }
   const targetClass = getTargetClass()
-  $: isState = targetClass === core.class.Status ?? false
+  $: isState = targetClass === core.class.Status
   const dispatch = createEventDispatcher()
 
   async function getCountStates (ids: Array<Ref<Doc>>): Promise<number> {

server-plugins/activity-resources/src/__tests__/references.test.ts

@@ -13,7 +13,7 @@
 // limitations under the License.
 //
 
-import { Class, Doc, Ref } from '@hcengineering/core'
+import { type Class, type Doc, type Ref } from '@hcengineering/core'
 import { EmptyMarkup, MarkupNodeType, jsonToMarkup } from '@hcengineering/text-core'
 
 import { getReferencesData } from '../references'

server-plugins/activity-resources/src/index.ts

@@ -14,32 +14,32 @@
 //
 
 import activity, {
-  ActivityMessage,
-  ActivityMessageControl,
-  DocAttributeUpdates,
-  DocUpdateMessage,
-  Reaction
+  type ActivityMessage,
+  type ActivityMessageControl,
+  type DocAttributeUpdates,
+  type DocUpdateMessage,
+  type Reaction
 } from '@hcengineering/activity'
 import core, {
-  PersonId,
-  AttachedDoc,
-  Class,
-  Collection,
-  Data,
-  Doc,
-  Hierarchy,
+  type PersonId,
+  type AttachedDoc,
+  type Class,
+  type Collection,
+  type Data,
+  type Doc,
+  type Hierarchy,
   matchQuery,
-  MeasureContext,
-  Ref,
-  Space,
-  Tx,
-  TxCreateDoc,
-  TxCUD,
+  type MeasureContext,
+  type Ref,
+  type Space,
+  type Tx,
+  type TxCreateDoc,
+  type TxCUD,
   TxProcessor
 } from '@hcengineering/core'
-import notification, { NotificationContent } from '@hcengineering/notification'
+import notification, { type NotificationContent } from '@hcengineering/notification'
 import { getResource, translate } from '@hcengineering/platform'
-import { ActivityControl, DocObjectCache } from '@hcengineering/server-activity'
+import { type ActivityControl, type DocObjectCache } from '@hcengineering/server-activity'
 import type { TriggerControl } from '@hcengineering/server-core'
 import {
   createCollabDocInfo,